Bindings core: merge wallet methods into single enum #1560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thibault-martinez
previously approved these changes
Nov 3, 2023
Alex6323
previously approved these changes
Nov 3, 2023
kwek20
suggested changes
Nov 3, 2023
There was a problem hiding this comment.
Missing the Response comment changes, like here:
https://github.com/iotaledger/iota-sdk/blob/54228655694e397d5a8f0107cf56250876c45b77/bindings/core/src/response.rs#L240C22-L240C22
Thoralf-M
dismissed stale reviews from Alex6323 and thibault-martinez
via
7760e30
kwek20
approved these changes
Nov 3, 2023
thibault-martinez
approved these changes
Nov 3, 2023
Alex6323
approved these changes
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Bindings core: merge wallet methods into single enum, because they are now all called on the wallet and not on a separated account anymore
Type of change
How the change has been tested
cargo test