Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ed25519 address generation from wallet #1586

Merged
merged 70 commits into from
Mar 7, 2024
Merged

Remove ed25519 address generation from wallet #1586

merged 70 commits into from
Mar 7, 2024

Conversation

Alex6323
Copy link
Contributor

@Alex6323 Alex6323 commented Nov 7, 2023 •
edited
Loading

Description of change

  • Removes Ed25519 address generation through the wallet
  • Moves the single address generation to the secret manager (separate PR)
  • Adds tests for the new method in the bindings

Note, that with this PR we remove emitting the event LedgerAddressGeneration, because this was done in generate_ed25519_address fn in the removed file sdk/src/wallet/core/operations/address_generation.rs. That isn't a problem though because it wasn't used by any wallet.

Links to any relevant issues

#1536

@Alex6323 Alex6323 linked an issue Nov 10, 2023 that may be closed by this pull request
Remove generate_ed25519_address() from the wallet? #1536
Closed
@Alex6323 Alex6323 marked this pull request as ready for review December 7, 2023 09:49
@Alex6323 Alex6323 marked this pull request as draft December 11, 2023 10:13
@Alex6323 Alex6323 marked this pull request as ready for review February 1, 2024 17:52
Thoralf-M
Thoralf-M reviewed Feb 1, 2024
View reviewed changes
bindings/core/src/lib.rs Outdated Show resolved Hide resolved
thibault-martinez
thibault-martinez requested changes Feb 6, 2024
View reviewed changes
Copy link
Member

@thibault-martinez thibault-martinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conflicts

@Alex6323 Alex6323 marked this pull request as draft February 16, 2024 22:29
@Alex6323 Alex6323 marked this pull request as ready for review March 7, 2024 11:09
@Alex6323 Alex6323 merged commit 85d30ef into iotaledger:2.0 Mar 7, 2024
37 checks passed
@Alex6323 Alex6323 deleted the refactor/wallet/remove-ed25519-address-generation branch March 7, 2024 15:24
@thibault-martinez thibault-martinez mentioned this pull request Mar 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Thoralf-M Thoralf-M Thoralf-M approved these changes

@DaughterOfMars DaughterOfMars DaughterOfMars approved these changes

@thibault-martinez thibault-martinez thibault-martinez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove generate_ed25519_address() from the wallet?
4 participants
@Alex6323 @thibault-martinez @DaughterOfMars @Thoralf-M