Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove AddressWithUnspentOutputs #1588

Closed
wants to merge 1 commit into from

Conversation

Thoralf-M
Copy link
Member

Description of change

Sorry Brord, another open PR

Links to any relevant issues

Be sure to reference any related issues by adding fixes #issue_number.

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How the change has been tested

Describe the tests that you ran to verify your changes.

Make sure to provide instructions for the maintainer as well as any relevant configurations.

@Thoralf-M Thoralf-M marked this pull request as draft November 7, 2023 13:44
@Thoralf-M Thoralf-M closed this Nov 10, 2023
@Thoralf-M Thoralf-M deleted the syncing-cleanup branch November 10, 2023 08:41
@thibault-martinez
Copy link
Member

Why?

@Thoralf-M
Copy link
Member Author

I think I changed too much to a single address, because we can still have multiple account and nft addresses
But couldn't really test without having much more changes before, so not worth it to wait in this state
Also many changes are done in #1604

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants