CLI wallet: Ledger Nano support

[Alex6323]

Description of change

Adds support for Ledger Nano to the CLI wallet and fixes some usability issues.

Links to any relevant issues

Closes #144

Type of change

Choose a type of change, and delete any options that are not relevant.

• Enhancement (a non-breaking change which adds functionality)

[Thoralf-M]

Can you remove let wallet = unlock_wallet(storage_path, None, None).await?; from node_info_command()?
We don't need this for a stronghold wallet and certainly not for a ledger nano one

Please also check if there are other places where one is requested to insert a pw even if not needed (not needed at all or just not needed with a ledger nano)

[Alex6323]

Can you remove let wallet = unlock_wallet(storage_path, None, None).await?; from node_info_command()? We don't need this for a stronghold wallet and certainly not for a ledger nano one

Please also check if there are other places where one is requested to insert a pw even if not needed (not needed at all or just not needed with a ledger nano)

Are sure you need to enter a password to run the node info command? I don't. As you can see from the line you posted, password is None.

[Alex6323]

Can you remove let wallet = unlock_wallet(storage_path, None, None).await?; from node_info_command()? We don't need this for a stronghold wallet and certainly not for a ledger nano one
Please also check if there are other places where one is requested to insert a pw even if not needed (not needed at all or just not needed with a ledger nano)

Are sure you need to enter a password to run the node info command? I don't. As you can see from the line you posted, password is None.

Actually during current implementation of handling several secret managers I came to realize that this should require a password atm, because this command uses the node as stored in the wallet, not just any node. Hence the node used should be considered private information. An alternative would be to require the URL, but I guess that's not what we want. We want the node info of the node that specifically is used to sync the wallet.

[Thoralf-M]

Running just cargo run --release has a different behavior (asks directly for stronghold pw) than running with init (shows secret manager selection)
Should both be like the init command?

[Thoralf-M]

Running a wallet command after it got initialized with ledger nano returns Stronghold snapshot not found at './stardust-cli-wallet.stronghold'. (get-info) or it asks for a stronghold password, just to then fail with wallet error: no mnemonic has been stored into the Stronghold vault (new-account)

[Alex6323]

Running a wallet command after it got initialized with ledger nano returns Stronghold snapshot not found at './stardust-cli-wallet.stronghold'. (get-info) or it asks for a stronghold password, just to then fail with wallet error: no mnemonic has been stored into the Stronghold vault (new-account)

how did you run the wallet? Stronghold is still the default secret manager if you don't pass -s <SECRET_MANAGER> to the binary.

[Thoralf-M]

Running a wallet command after it got initialized with ledger nano returns Stronghold snapshot not found at './stardust-cli-wallet.stronghold'. (get-info) or it asks for a stronghold password, just to then fail with wallet error: no mnemonic has been stored into the Stronghold vault (new-account)

how did you run the wallet? Stronghold is still the default secret manager if you don't pass -s <SECRET_MANAGER> to the binary.

Just cargo run --release get-info (before initialized with ledger nano)

[Alex6323]

Running a wallet command after it got initialized with ledger nano returns Stronghold snapshot not found at './stardust-cli-wallet.stronghold'. (get-info) or it asks for a stronghold password, just to then fail with wallet error: no mnemonic has been stored into the Stronghold vault (new-account)

how did you run the wallet? Stronghold is still the default secret manager if you don't pass -s <SECRET_MANAGER> to the binary.

Just cargo run --release get-info (before initialized with ledger nano)

gonna fix the quirks ...

[thibault-martinez]

(don't merge yet please, still having a look)

[thibault-martinez]

Conflict