Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax implicit account requirements #1612

Merged
merged 2 commits into from
Nov 13, 2023

Conversation

tadzik
Copy link
Contributor

@tadzik tadzik commented Nov 13, 2023

Description of change

Following the changes in iotaledger/iota.go#604, we relax the requirements for what we treat as an implicit account creation.

The restrictions in there wrt the allowed featureset is something we'll need to add later, once we introduce the creation of implicit accounts.

Type of change

  • Breaking change (is it?)

How the change has been tested

The tests still pass, but they don't to exercise this code path at all. Is it the right time to introduce them?

Change checklist

Tick the boxes that are relevant to your changes, and delete any items that are not.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes

@thibault-martinez thibault-martinez merged commit 5ca64a3 into 2.0 Nov 13, 2023
24 of 35 checks passed
@thibault-martinez thibault-martinez deleted the relax-implicit-account-requirements branch November 13, 2023 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants