Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add parameters suffix to version signaling #1668

Merged
merged 2 commits into from
Nov 23, 2023
Merged

Add parameters suffix to version signaling #1668

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
403b115
Add parameters suffix to version signaling
thibault-martinez Nov 22, 2023
7e03f52
Merge branch '2.0' into version-signaling-parameters
thibault-martinez Nov 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bindings/nodejs/lib/types/models/info/node-info-protocol.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ export interface ProtocolParameters {
/**
* The parameters used by signaling protocol parameters upgrade.
*/
versionSignaling: VersionSignalingParameters;
versionSignalingParameters: VersionSignalingParameters;
/**
* Rewards Parameters defines the parameters that are used to calculate Mana rewards.
*/
Expand Down
6 changes: 3 additions & 3 deletions bindings/python/iota_sdk/types/node_info.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ class CongestionControlParameters:

@json
@dataclass
class VersionSignaling:
class VersionSignalingParameters:
"""Version Signaling defines the parameters used by signaling protocol parameters upgrade.

Attributes:
Expand Down Expand Up @@ -237,7 +237,7 @@ class ProtocolParameters:
max_committable_age: Max_committable_age is the maximum age for a slot commitment to be included in a block relative to the slot index of the block issuing time.
epoch_nearing_threshold: Determine the slot that should trigger a new committee selection for the next and upcoming epoch.
congestion_control_parameters: Congestion Control Parameters defines the parameters used to calculate the Reference Mana Cost (RMC).
version_signaling: The version signaling parameters.
version_signaling_parameters: The version signaling parameters.
rewards_parameters: Rewards Parameters defines the parameters that are used to calculate Mana rewards.
"""
type: int
Expand Down Expand Up @@ -271,7 +271,7 @@ class ProtocolParameters:
encoder=str
))
congestion_control_parameters: CongestionControlParameters
version_signaling: VersionSignaling
version_signaling_parameters: VersionSignalingParameters
rewards_parameters: RewardsParameters


Expand Down
4 changes: 2 additions & 2 deletions sdk/src/types/block/protocol.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ pub struct ProtocolParameters {
/// Parameters used to calculate the Reference Mana Cost (RMC).
pub(crate) congestion_control_parameters: CongestionControlParameters,
/// Defines the parameters used to signal a protocol parameters upgrade.
pub(crate) version_signaling: VersionSignalingParameters,
pub(crate) version_signaling_parameters: VersionSignalingParameters,
/// Defines the parameters used for reward calculation.
pub(crate) rewards_parameters: RewardsParameters,
/// Defines the target size of the committee. If there's fewer candidates the actual committee size could be
Expand Down Expand Up @@ -122,7 +122,7 @@ impl Default for ProtocolParameters {
min_committable_age: 10,
max_committable_age: 20,
congestion_control_parameters: Default::default(),
version_signaling: Default::default(),
version_signaling_parameters: Default::default(),
rewards_parameters: Default::default(),
target_committee_size: 32,
}
Expand Down
2 changes: 1 addition & 1 deletion sdk/tests/types/protocol.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@
// "maxBufferSize":1000,
// "maxValidationBufferSize":100
// },
// "versionSignaling":{
// "versionSignalingParameters":{
// "windowSize":7,
// "windowTargetRatio":5,
// "activationOffset":7
Expand Down
Loading