Address some TODOs #1681
Merged
Address some TODOs #1681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thibault-martinez
approved these changes
Nov 24, 2023
kwek20
reviewed
Nov 25, 2023
| @@ -145,7 +145,6 @@ impl SecretManage for LedgerSecretManager { | |||
| ) -> Result<Vec<ed25519::PublicKey>, Self::Error> { | |||
| // need an update on the ledger C lib | |||
| todo!(); | |||
| // | |||
There was a problem hiding this comment.
thats not addressing the todo :D
kwek20
approved these changes
Nov 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Address some TODOs, in rand_basic_output() NTs are now added as feature already
Type of change