Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add API response tests from TIP examples #1687

Merged
merged 57 commits into from
Jan 25, 2024
Merged

Add API response tests from TIP examples #1687

merged 57 commits into from
Jan 25, 2024

Conversation

thibault-martinez
Copy link
Member

Fixes #1663

@thibault-martinez thibault-martinez marked this pull request as ready for review January 25, 2024 08:51
@thibault-martinez thibault-martinez linked an issue Jan 25, 2024 that may be closed by this pull request
Add test parsing all API response examples from the TIP #1663
Closed
DaughterOfMars
DaughterOfMars reviewed Jan 25, 2024
View reviewed changes
Copy link

@DaughterOfMars DaughterOfMars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Care about the missing newlines in the json files?

@thibault-martinez
Copy link
Member Author

Care about the missing newlines in the json files?

no

@DaughterOfMars DaughterOfMars merged commit e5adb22 into iotaledger:2.0 Jan 25, 2024
21 checks passed
@thibault-martinez thibault-martinez deleted the api-tips-example-test branch January 25, 2024 14:51
@thibault-martinez thibault-martinez mentioned this pull request Jan 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaughterOfMars DaughterOfMars DaughterOfMars approved these changes

@Thoralf-M Thoralf-M Thoralf-M approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add test parsing all API response examples from the TIP
3 participants
@thibault-martinez @DaughterOfMars @Thoralf-M