-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python/single account #1757
Merged
thibault-martinez
merged 55 commits into
iotaledger:2.0
from
kwek20:python/single-account
Dec 20, 2023
Merged
Python/single account #1757
thibault-martinez
merged 55 commits into
iotaledger:2.0
from
kwek20:python/single-account
Dec 20, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thoralf-M
reviewed
Dec 11, 2023
Thoralf-M
reviewed
Dec 11, 2023
Thoralf-M
reviewed
Dec 12, 2023
Thoralf-M
reviewed
Dec 12, 2023
Thoralf-M
reviewed
Dec 12, 2023
Thoralf-M
previously approved these changes
Dec 14, 2023
Alex6323
previously approved these changes
Dec 15, 2023
thibault-martinez
dismissed stale reviews from Thoralf-M and Alex6323
via
December 18, 2023 15:36
313e79b
bindings/python/examples/how_tos/accounts_and_addresses/create_address.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we removing 15 examples?
thibault-martinez
requested changes
Dec 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI failing
You may have reverted a bit too much btw |
thibault-martinez
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Update python to work with account.
Removed (hopefully) all account references that mean wallet
added an implicit account example (untested flow due to faucet)
Links to any relevant issues
fixes #1423
Type of change
How the change has been tested
ran tests and some examples.