Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python/single account #1757

Merged
merged 55 commits into from
Dec 20, 2023
Merged

Conversation

kwek20
Copy link
Contributor

@kwek20 kwek20 commented Dec 7, 2023

Description of change

Update python to work with account.
Removed (hopefully) all account references that mean wallet
added an implicit account example (untested flow due to faucet)

Links to any relevant issues

fixes #1423

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How the change has been tested

ran tests and some examples.

@kwek20 kwek20 marked this pull request as draft December 7, 2023 12:36
@kwek20 kwek20 marked this pull request as ready for review December 11, 2023 15:47
Thoralf-M
Thoralf-M previously approved these changes Dec 14, 2023
Alex6323
Alex6323 previously approved these changes Dec 15, 2023
Copy link
Member

@thibault-martinez thibault-martinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we removing 15 examples?

Copy link
Member

@thibault-martinez thibault-martinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI failing

@thibault-martinez
Copy link
Member

You may have reverted a bit too much btw

@thibault-martinez thibault-martinez merged commit 0b075b4 into iotaledger:2.0 Dec 20, 2023
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants