Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Wallet events improvements #2100

Conversation

marc2332
Copy link
Contributor

@marc2332 marc2332 commented Feb 29, 2024

Description of change

  • Reorder wallet events (emit SigningTransaction before PreparedTransactionSigningHash, emit Broadcasting after signing the block)
  • Add a new PreparedBlockSigningInput event
  • Updated Nodejs and python bindings

Links to any relevant issues

Fixes #2054

Type of change

  • Enhancement

How the change has been tested

Firefly and SDK tests

Change checklist

Tick the boxes that are relevant to your changes, and delete any items that are not.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
    • Update the tests accordingly
    • Avoid relying on TransactionSigningHash for the block signing hash
  • I have checked that new and existing unit tests pass locally with my changes

@marc2332 marc2332 marked this pull request as ready for review March 1, 2024 09:59
Copy link
Member

@Thoralf-M Thoralf-M left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marc2332 marc2332 requested a review from Thoralf-M March 5, 2024 08:26
@marc2332
Copy link
Contributor Author

marc2332 commented Mar 5, 2024

CI is failing but should be fixed by #2131

@marc2332 marc2332 requested a review from Thoralf-M March 5, 2024 08:56
@marc2332 marc2332 requested a review from Thoralf-M March 5, 2024 11:08
@marc2332 marc2332 requested a review from Thoralf-M March 5, 2024 11:17
@marc2332 marc2332 requested a review from Thoralf-M March 5, 2024 11:57
Copy link
Member

@thibault-martinez thibault-martinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@thibault-martinez thibault-martinez merged commit 9e70832 into iotaledger:2.0 Mar 5, 2024
37 checks passed
@thibault-martinez thibault-martinez linked an issue Mar 5, 2024 that may be closed by this pull request
@marc2332 marc2332 deleted the feat/wallet-events-improvements branch March 5, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Emit block signing event with signing input
4 participants