-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better input ordering #2175
Merged
Merged
Better input ordering #2175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thoralf-M
reviewed
Mar 12, 2024
Thoralf-M
approved these changes
Mar 12, 2024
Thoralf-M
requested changes
Mar 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Failing test
Thoralf-M
reviewed
Mar 12, 2024
DaughterOfMars
force-pushed
the
feat/input-order
branch
from
March 13, 2024 17:10
b9bfd76
to
e7d0dac
Compare
Thoralf-M
reviewed
Mar 13, 2024
Thoralf-M
reviewed
Mar 13, 2024
Thoralf-M
reviewed
Mar 13, 2024
Thoralf-M
reviewed
Mar 14, 2024
Thoralf-M
previously approved these changes
Mar 14, 2024
DaughterOfMars
changed the title
Order inputs on selection instead of sorting later
Better input ordering
Mar 15, 2024
Thoralf-M
approved these changes
Mar 15, 2024
Alex6323
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Previously, we sorted the inputs when the builder is finished (and in the mana requirement) but this was unnecessary as we can sort them when selecting instead and just maintain the sorted order.
UPDATE: After some re-evaluation, the above approach is not possible because inputs may be added that have requirements that have not yet been selected, but will be later. This would then need basically the same re-sorting logic. Instead, I implemented a custom collection which holds useful information for ordering the inputs and handles the actual order in the iterator implementations. This does require some additional memory overhead per reference iterator call (but not for consuming iteration): An additional
VecDeque
andBTreeMap
are allocated, plus oneVecDeque
per non-ed25519 address.