-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLI: improve wallet creation #2183
Merged
Alex6323
merged 18 commits into
iotaledger:2.0
from
Alex6323:cli/improve-init-parameters
Mar 21, 2024
Merged
CLI: improve wallet creation #2183
Alex6323
merged 18 commits into
iotaledger:2.0
from
Alex6323:cli/improve-init-parameters
Mar 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Thoralf-M
reviewed
Mar 19, 2024
Co-authored-by: DaughterOfMars <[email protected]>
Thoralf-M
reviewed
Mar 19, 2024
Thoralf-M
reviewed
Mar 19, 2024
Thoralf-M
reviewed
Mar 19, 2024
Thoralf-M
reviewed
Mar 19, 2024
Alex6323
force-pushed
the
cli/improve-init-parameters
branch
from
March 19, 2024 11:57
a9f2176
to
860d3ed
Compare
Co-authored-by: DaughterOfMars <[email protected]>
DaughterOfMars
previously approved these changes
Mar 19, 2024
Thoralf-M
reviewed
Mar 20, 2024
DaughterOfMars
previously approved these changes
Mar 20, 2024
Thoralf-M
reviewed
Mar 21, 2024
Thoralf-M
approved these changes
Mar 21, 2024
DaughterOfMars
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
This PR suggests the changes:
alias
in theInitParameters
, because that just seems right to allow that;InitParameters
, because defaulting to a certain network could be confusing for some users;Links to any relevant issues
Fixes #2052