Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wasm compilation, bump wasm-bindgen #2221

Merged
merged 3 commits into from
Apr 16, 2024

Conversation

Thoralf-M
Copy link
Member

@Thoralf-M Thoralf-M commented Apr 15, 2024

Description of change

Fix wasm compilation that broke with the latest rust version, see https://github.com/iotaledger/iota-sdk/actions/runs/8689172617/job/23826349127?pr=2220

Type of change

  • Bug fix (a non-breaking change which fixes an issue)

How the change has been tested

Compiled it

@Thoralf-M
Copy link
Member Author

Linting fails because of #2072

@Thoralf-M Thoralf-M marked this pull request as ready for review April 15, 2024 13:52
@Thoralf-M Thoralf-M merged commit fba9feb into iotaledger:develop Apr 16, 2024
37 of 38 checks passed
@Thoralf-M Thoralf-M deleted the fix-wasm-compilation branch April 16, 2024 07:45
Thoralf-M added a commit that referenced this pull request May 7, 2024
* Fix nightly build (#1981)

* Fix TransactionOptions::as_dict() for remainder_value_strategy (#1993)

* Fix ClientOptions typing in wallet options (#1994)

* Bump version and set release date (#1996)

* Fix node.js readme example (#2220)

* Fix wasm compilation, bump wasm-bindgen (#2221)

* Fix wasm compilation, bump wasm-bindgen

* Update dependencies

* Fix: make TaggedData data field optional (#1983)

* Make TaggedDataPayload::data field optional

* Tag also optional, still failing

* Make TaggedDataPayload work

* Uncomment, fix imports and lint

* Raise error

* Update date

* reorder union

* Remove unused import, update changelog, bump version

* Update rustls

---------

Co-authored-by: Alex Coats <[email protected]>

* Update private tangle action

---------

Co-authored-by: Thibault Martinez <[email protected]>
Co-authored-by: Dr-Electron <[email protected]>
Co-authored-by: Alex Coats <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants