Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change the new to new-account, set-node to set-node-url in wallet CLI #601

Merged
merged 8 commits into from
Jun 15, 2023

Conversation

qrayven
Copy link
Contributor

@qrayven qrayven commented Jun 14, 2023

Description of change

changes for better UX:
-> new to new-account
-> set-node set-node-url

Links to any relevant issues

Part of: #389

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Change checklist

Tick the boxes that are relevant to your changes, and delete any items that are not.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes

@qrayven qrayven marked this pull request as ready for review June 14, 2023 08:59
sdk/CHANGELOG.md Outdated Show resolved Hide resolved
@Alex6323
Copy link
Contributor

I am okay with this ... but .. can you fix the PR title 😂 and mark it a breaking change?

@qrayven qrayven changed the title imporove UX for CLI names change the new to new-account, set-node to set-node-url in wallet CLI Jun 14, 2023
@qrayven
Copy link
Contributor Author

qrayven commented Jun 14, 2023

I am okay with this ... but .. can you fix the PR title joy and mark it a breaking change?

what a typo, thanks :D

DaughterOfMars
DaughterOfMars previously approved these changes Jun 14, 2023
cli/README.md Outdated Show resolved Hide resolved
@thibault-martinez thibault-martinez merged commit 8990c3c into iotaledger:develop Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants