Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mqtt milestone #662

Merged
merged 1 commit into from
Jun 22, 2023
Merged

Fix mqtt milestone #662

merged 1 commit into from
Jun 22, 2023

Conversation

kwek20
Copy link
Contributor

@kwek20 kwek20 commented Jun 22, 2023

Description of change

The mqtt milestone topic wasnt sending anything back due to wrong unpacking

Type of change

  • Bug fix (a non-breaking change which fixes an issue)

How the change has been tested

Ran mqtt milestones topic and received milestones

Change checklist

Tick the boxes that are relevant to your changes, and delete any items that are not.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes

@thibault-martinez thibault-martinez merged commit fb88ea1 into iotaledger:develop Jun 22, 2023
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thibault-martinez thibault-martinez thibault-martinez approved these changes

@Thoralf-M Thoralf-M Thoralf-M approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kwek20 @thibault-martinez @Thoralf-M