-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add some client examples to docs #669
Merged
thibault-martinez
merged 18 commits into
iotaledger:develop
from
Dr-Electron:docs/client-examples
Jun 26, 2023
Merged
Add some client examples to docs #669
thibault-martinez
merged 18 commits into
iotaledger:develop
from
Dr-Electron:docs/client-examples
Jun 26, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thoralf-M
reviewed
Jun 23, 2023
Thoralf-M
reviewed
Jun 23, 2023
Co-authored-by: Thoralf-M <[email protected]>
Co-authored-by: Thibault Martinez <[email protected]>
thibault-martinez
previously approved these changes
Jun 26, 2023
thibault-martinez
previously approved these changes
Jun 26, 2023
kwek20
reviewed
Jun 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Soooo for the nodejs example output (output=result of running a command) weve updated the types so now they have a differnet output. Whats the strategy for this? when do we update the output?
kwek20
reviewed
Jun 26, 2023
kwek20
reviewed
Jun 26, 2023
thibault-martinez
approved these changes
Jun 26, 2023
Thoralf-M
approved these changes
Jun 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Added some client examples.
TODOs:
get_node_health
instead ofget_health
. And the function is broken. I will update itLinks to any relevant issues
Fixes #599
Type of change
How the change has been tested
Tested locally
Change checklist