New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove client block builder #674

Merged

thibault-martinez merged 5 commits into iotaledger:2.0 from Thoralf-M:Remove-client-block-builder

Jun 29, 2023

Member

Thoralf-M commented Jun 23, 2023

Description of change

Remove client block builder. The wallet should be used to build transactions in the future (people can still build payloads themselves and submit them)

Type of change

Breaking change (fix or feature that would cause existing functionality to not work as expected)

How the change has been tested

cargo check, test

Change checklist

I have followed the contribution guidelines for this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
I have added tests that prove my fix is effective or that my feature works
I have checked that new and existing unit tests pass locally with my changes

Thoralf-M marked this pull request as draft

June 23, 2023 15:40

Member Author

Thoralf-M commented Jun 23, 2023

Will rebase after #671

Thoralf-M force-pushed the Remove-client-block-builder branch 2 times, most recently from 7377487 to ab9e351 Compare

June 23, 2023 17:50

Thoralf-M marked this pull request as ready for review

June 23, 2023 17:50

kwek20 reviewed

View reviewed changes

bindings/core/src/response.rs Show resolved Hide resolved

thibault-martinez force-pushed the 2.0 branch from 05ed986 to 1535a10 Compare

June 26, 2023 07:39

Thoralf-M force-pushed the Remove-client-block-builder branch 2 times, most recently from 402d747 to 16d7b82 Compare

June 27, 2023 08:12

thibault-martinez force-pushed the 2.0 branch from 1535a10 to 2c06dd4 Compare

June 27, 2023 11:08

Thoralf-M force-pushed the Remove-client-block-builder branch 3 times, most recently from d878ff2 to 2d08913 Compare

June 27, 2023 13:09

Thoralf-M mentioned this pull request

Remove metadata from output endpoint #673

Merged

thibault-martinez force-pushed the 2.0 branch from fdd2f3e to 6917048 Compare

June 28, 2023 10:01

Thoralf-M force-pushed the Remove-client-block-builder branch from 2d08913 to 7c89886 Compare

June 28, 2023 10:05

thibault-martinez requested changes

View reviewed changes

Member

thibault-martinez left a comment

Failing CI

thibault-martinez reviewed

View reviewed changes

bindings/nodejs/examples/client/08-data-block.ts Outdated Show resolved Hide resolved

thibault-martinez reviewed

View reviewed changes

sdk/examples/client/block/00_block_no_payload.rs Show resolved Hide resolved

thibault-martinez reviewed

View reviewed changes

bindings/python/examples/client/post_raw_block.py Outdated Show resolved Hide resolved

thibault-martinez requested changes

View reviewed changes

Member

thibault-martinez left a comment

Failing CI

thibault-martinez reviewed

View reviewed changes

bindings/python/examples/client/06_simple_block.py Outdated Show resolved Hide resolved

thibault-martinez reviewed

View reviewed changes

sdk/examples/client/ledger_nano_transaction.rs Show resolved Hide resolved

thibault-martinez force-pushed the 2.0 branch from 6917048 to ac6cb09 Compare

June 28, 2023 18:50

Thoralf-M added 4 commits

June 28, 2023 21:22


          Remove client block builder

7b1be80


          Add imports

9d97df0


          Remove unused import

4df92c1


          Fix example

7a6e797

Thoralf-M force-pushed the Remove-client-block-builder branch from 5838e9e to 7a6e797 Compare

June 28, 2023 19:23

thibault-martinez previously approved these changes

View reviewed changes

Alex6323 reviewed

View reviewed changes

bindings/nodejs/examples/client/06-simple-block.ts Outdated Show resolved Hide resolved

Alex6323 reviewed

View reviewed changes

bindings/nodejs/tests/client/examples.spec.ts Outdated Show resolved Hide resolved


          Add issue link

60b034b

Thoralf-M dismissed thibault-martinez’s stale review via

60b034b

June 29, 2023 07:47

Alex6323 approved these changes

View reviewed changes

thibault-martinez approved these changes

View reviewed changes

qrayven approved these changes

View reviewed changes

kwek20 approved these changes

View reviewed changes

thibault-martinez merged commit c3d5f5c into iotaledger:2.0

Thoralf-M deleted the Remove-client-block-builder branch

June 29, 2023 10:01

thibault-martinez pushed a commit that referenced this pull request


          Remove client block builder (#674)

65b085a

* Remove client block builder

* Add imports

* Remove unused import

* Fix example

* Add issue link

thibault-martinez pushed a commit that referenced this pull request


          Remove client block builder (#674)

00972f9

* Remove client block builder

* Add imports

* Remove unused import

* Fix example

* Add issue link

thibault-martinez pushed a commit that referenced this pull request


          Remove client block builder (#674)

890c04a

* Remove client block builder

* Add imports

* Remove unused import

* Fix example

* Add issue link

thibault-martinez pushed a commit that referenced this pull request


          Remove client block builder (#674)

* Remove client block builder

* Add imports

* Remove unused import

* Fix example

* Add issue link

DaughterOfMars pushed a commit that referenced this pull request


          Remove client block builder (#674)

08f4e72

* Remove client block builder

* Add imports

* Remove unused import

* Fix example

* Add issue link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet