-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Added client destroy #679
Feat: Added client destroy #679
Conversation
In the tests it still prints |
Question: Setting to undefined is useful at all? I have no idea |
…into fix/nodejs-handle
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Conflicts
Description of change
client had an open handle, now you can close it!
Links to any relevant issues
fixes #520
Type of change
Choose a type of change, and delete any options that are not relevant.
How the change has been tested
added it to test fixtures, no longer does jest complain! :carlos:
Make sure to provide instructions for the maintainer as well as any relevant configurations.
Change checklist
Tick the boxes that are relevant to your changes, and delete any items that are not.