Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Added client destroy #679

Merged
merged 16 commits into from
Jun 29, 2023

Conversation

kwek20
Copy link
Contributor

@kwek20 kwek20 commented Jun 26, 2023

Description of change

client had an open handle, now you can close it!

Links to any relevant issues

fixes #520

Type of change

Choose a type of change, and delete any options that are not relevant.

  • Bug fix (a non-breaking change which fixes an issue)

How the change has been tested

added it to test fixtures, no longer does jest complain! :carlos:

Make sure to provide instructions for the maintainer as well as any relevant configurations.

Change checklist

Tick the boxes that are relevant to your changes, and delete any items that are not.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes

@Thoralf-M
Copy link
Member

In the tests it still prints Force exiting Jest: Have you considered using --detectOpenHandles to detect async operations that kept running after all tests finished?
Do we need the same for the SecretManager or does the destroy just need to be called in some other tests as well?

@kwek20
Copy link
Contributor Author

kwek20 commented Jun 27, 2023

Question: Setting to undefined is useful at all? I have no idea

Thoralf-M
Thoralf-M previously approved these changes Jun 29, 2023
Copy link
Member

@thibault-martinez thibault-martinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conflicts

@thibault-martinez thibault-martinez merged commit 2e9fe16 into iotaledger:develop Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Open handle on NodeJS Client
4 participants