Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split block into basic and validation types #928

Merged
merged 44 commits into from
Aug 4, 2023
Merged

Split block into basic and validation types #928

merged 44 commits into from
Aug 4, 2023

Conversation

DaughterOfMars
Copy link

@DaughterOfMars DaughterOfMars commented Jul 25, 2023 •
edited
Loading

Description of change

This splits blocks into two possible types.

Links to any relevant issues

Base automatically changed from feat/parents to 2.0 July 26, 2023 13:34
kwek20
kwek20 reviewed Aug 1, 2023
View reviewed changes
Copy link
Contributor

@kwek20 kwek20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

init few, now i delve into block :D

sdk/src/client/api/block_builder/mod.rs Outdated Show resolved Hide resolved
sdk/src/lib.rs Show resolved Hide resolved
sdk/src/types/api/plugins/participation/mod.rs Outdated Show resolved Hide resolved
sdk/src/client/api/high_level.rs Outdated Show resolved Hide resolved
Thoralf-M
Thoralf-M previously approved these changes Aug 1, 2023
View reviewed changes
kwek20
kwek20 reviewed Aug 2, 2023
View reviewed changes
sdk/src/types/block/core.rs Outdated Show resolved Hide resolved
kwek20
kwek20 reviewed Aug 2, 2023
View reviewed changes
sdk/src/types/block/core.rs Outdated Show resolved Hide resolved
kwek20
kwek20 previously approved these changes Aug 2, 2023
View reviewed changes
Copy link
Contributor

@kwek20 kwek20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shame of the duplicate methods in block and wrapper but not easily handle-able i think

Thoralf-M
Thoralf-M previously approved these changes Aug 2, 2023
View reviewed changes
@DaughterOfMars DaughterOfMars dismissed stale reviews from Thoralf-M and kwek20 via 0ada1bb August 3, 2023 09:45
This was linked to issues Aug 4, 2023
Change Block into BasicBlock - rust #868
Closed
Add ValidationBlock - rust #874
Closed
Add Block wrapper - rust #877
Closed
@Thoralf-M Thoralf-M merged commit 46578d4 into 2.0 Aug 4, 2023
19 checks passed
@DaughterOfMars DaughterOfMars deleted the feat/split-block branch August 4, 2023 15:04
@DaughterOfMars DaughterOfMars mentioned this pull request Aug 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Thoralf-M Thoralf-M Thoralf-M approved these changes

@abdulmth abdulmth abdulmth approved these changes

@qrayven qrayven qrayven approved these changes

@Alex6323 Alex6323 Awaiting requested review from Alex6323

@thibault-martinez thibault-martinez Awaiting requested review from thibault-martinez

@kwek20 kwek20 Awaiting requested review from kwek20

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Block wrapper - rust Add ValidationBlock - rust Change Block into BasicBlock - rust
7 participants
@DaughterOfMars @kwek20 @thibault-martinez @qrayven @abdulmth @Alex6323 @Thoralf-M