Return error on secret manager mismatch #946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alex6323
changed the title
Thoralf-M
previously approved these changes
Jul 28, 2023
DaughterOfMars
previously approved these changes
Jul 28, 2023
Thoralf-M
approved these changes
Jul 29, 2023
thibault-martinez
approved these changes
Jul 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
In some cases we just return an
Ok(())on some stronghold related wallet methods even if the internally used secret manager is something else than a stronghold secret manager. This I think might be confusing to the user. This PR changes this behavior and will consistently return an error instead if a stronghold-only operation is tried to be called on some other secret manager.Links to any relevant issues
None
Type of change