Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(logging): change some debug logs to warnings and errors #958

Merged
merged 3 commits into from
Jul 28, 2023
Merged

chore(logging): change some debug logs to warnings and errors #958

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
31894a2
change some debug logs to warnings and errors
Alex6323 Jul 27, 2023
fb23772
revert some
Alex6323 Jul 28, 2023
6a0c05f
Merge branch '1.1' into chore/logging/warnings-and-errors
Alex6323 Jul 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bindings/nodejs/src/client.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ impl ClientMethodHandler {
(msg, is_err)
}
Err(e) => {
log::debug!("{:?}", e);
log::error!("{:?}", e);
(format!("Couldn't parse to method with error - {e:?}"), true)
}
}
Expand Down
2 changes: 1 addition & 1 deletion bindings/nodejs/src/secret_manager.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ impl SecretManagerMethodHandler {
(msg, is_err)
}
Err(e) => {
log::debug!("{:?}", e);
log::error!("{:?}", e);
(format!("Couldn't parse to method with error - {e:?}"), true)
}
}
Expand Down
2 changes: 1 addition & 1 deletion bindings/nodejs/src/wallet.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ impl WalletMethodHandler {
(msg, is_err)
}
Err(e) => {
log::debug!("{:?}", e);
log::error!("{:?}", e);
(
serde_json::to_string(&Response::Error(e.into())).expect("json to string error"),
true,
Expand Down
2 changes: 1 addition & 1 deletion sdk/src/client/node_manager/syncing.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ impl ClientInner {
}
}
} else {
log::debug!("{} is not healthy: {:?}", node.url, info);
log::warn!("{} is not healthy: {:?}", node.url, info);
}
}
Err(err) => {
Expand Down
Loading