Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make private fields readonly #961

Merged
merged 9 commits into from
Jul 28, 2023

Conversation

Tuditi
Copy link
Contributor

@Tuditi Tuditi commented Jul 28, 2023

Description of change

Changes the types of a class from private to readonly, so the dev experience of TS users increases.

Type of change

Choose a type of change, and delete any options that are not relevant.

  • Enhancement (a non-breaking change which adds functionality)

How the change has been tested

Tested within firefly.

Change checklist

Tick the boxes that are relevant to your changes, and delete any items that are not.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes

@Tuditi Tuditi marked this pull request as ready for review July 28, 2023 08:47
@thibault-martinez
Copy link
Member

(ignore the latest comment, GH bug)

@thibault-martinez thibault-martinez merged commit fffcdc5 into iotaledger:develop Jul 28, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants