-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: make private fields readonly #961
Merged
thibault-martinez
merged 9 commits into
iotaledger:develop
from
Tuditi:fix/private-to-readonly
Jul 28, 2023
Merged
chore: make private fields readonly #961
thibault-martinez
merged 9 commits into
iotaledger:develop
from
Tuditi:fix/private-to-readonly
Jul 28, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tuditi
force-pushed
the
fix/private-to-readonly
branch
from
July 28, 2023 10:57
d6de7cb
to
88c40c9
Compare
thibault-martinez
previously approved these changes
Jul 28, 2023
abdulmth
suggested changes
Jul 28, 2023
Tuditi
force-pushed
the
fix/private-to-readonly
branch
from
July 28, 2023 11:40
66cf7b4
to
a544ca8
Compare
Tuditi
force-pushed
the
fix/private-to-readonly
branch
from
July 28, 2023 11:41
a544ca8
to
ed16aa2
Compare
Tuditi
force-pushed
the
fix/private-to-readonly
branch
from
July 28, 2023 11:42
ed16aa2
to
2d1fdbd
Compare
abdulmth
suggested changes
Jul 28, 2023
Co-authored-by: Abdulrahim Al Methiab <[email protected]>
abdulmth
approved these changes
Jul 28, 2023
thibault-martinez
approved these changes
Jul 28, 2023
(ignore the latest comment, GH bug) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Changes the types of a class from private to readonly, so the dev experience of TS users increases.
Type of change
Choose a type of change, and delete any options that are not relevant.
How the change has been tested
Tested within firefly.
Change checklist
Tick the boxes that are relevant to your changes, and delete any items that are not.