New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add `CommitmentInput` and `BlockIssuanceCreditInput` #981

Merged

abdulmth merged 16 commits into iotaledger:2.0 from abdulmth:feat/commitment-and-block-issuance-credit-inputs

Aug 3, 2023

Contributor

abdulmth commented Aug 1, 2023

Links to any relevant issues

fixes #901
fixes #906

Type of change

Choose a type of change, and delete any options that are not relevant.

Enhancement (a non-breaking change which adds functionality)

abdulmth added 5 commits

August 1, 2023 11:13


          add commitment and block issuance credit inputs

dfc7adc


          add tests

5f628d1


          add fn documentation

2d78d92


          improve test

5c84265

fix

7768dc9

abdulmth commented

View reviewed changes

sdk/src/types/block/context_input/mod.rs Show resolved Hide resolved

fmt

10ffe84

thibault-martinez reviewed

View reviewed changes

sdk/src/types/block/context_input/mod.rs Outdated Show resolved Hide resolved

thibault-martinez reviewed

View reviewed changes

sdk/src/types/block/context_input/mod.rs Outdated Show resolved Hide resolved

thibault-martinez reviewed

View reviewed changes

sdk/src/types/block/context_input/mod.rs Outdated Show resolved Hide resolved

abdulmth added 2 commits

August 1, 2023 12:28


          remove spaces between fields

5fcd4bc


          imporve order of methods

c0e9ce4

abdulmth marked this pull request as ready for review

August 1, 2023 10:33

thibault-martinez reviewed

View reviewed changes

sdk/src/types/block/context_input/mod.rs Outdated Show resolved Hide resolved

thibault-martinez reviewed

View reviewed changes

sdk/src/types/block/context_input/commitment.rs Outdated Show resolved Hide resolved


          improve panic message

f65846d

thibault-martinez reviewed

View reviewed changes

sdk/src/types/block/context_input/commitment.rs Outdated Show resolved Hide resolved

thibault-martinez reviewed

View reviewed changes

sdk/src/types/block/context_input/mod.rs Show resolved Hide resolved

abdulmth added 2 commits

August 1, 2023 13:22


          alternate is_ and as_ methods

2f49f19


          fix commitment documentation

21e7e41

thibault-martinez previously approved these changes

View reviewed changes

qrayven previously approved these changes

View reviewed changes

kwek20 reviewed

View reviewed changes

sdk/src/types/block/context_input/block_issuance_credit.rs Show resolved Hide resolved

kwek20 previously approved these changes

View reviewed changes

DaughterOfMars reviewed

View reviewed changes

sdk/src/types/block/context_input/block_issuance_credit.rs Show resolved Hide resolved

DaughterOfMars requested changes

View reviewed changes

DaughterOfMars left a comment

Now that the DTO PR is merged, this should be refactored to match.

The dto modules should be private.
There should be impl_typed_serde_dto! calls for each variant dto
The enum should derive serde and be untagged


          improve DTOs

f482fb1

abdulmth dismissed stale reviews from kwek20, qrayven, and thibault-martinez via

f482fb1

August 1, 2023 20:22

DaughterOfMars reviewed

View reviewed changes

sdk/src/types/block/context_input/block_issuance_credit.rs Outdated Show resolved Hide resolved

DaughterOfMars reviewed

View reviewed changes

sdk/src/types/block/context_input/reward.rs Outdated Show resolved Hide resolved

DaughterOfMars reviewed

View reviewed changes

sdk/src/types/block/context_input/commitment.rs Outdated Show resolved Hide resolved

abdulmth added 2 commits

August 1, 2023 22:34


          fix missing import

1f66a3f


          fix macro call

462ef9a

abdulmth commented

View reviewed changes

sdk/src/types/block/context_input/block_issuance_credit.rs Show resolved Hide resolved


          fix macro calls

2f347c2

Thoralf-M reviewed

View reviewed changes

sdk/src/types/block/context_input/block_issuance_credit.rs Outdated Show resolved Hide resolved

abdulmth requested a review from DaughterOfMars

August 2, 2023 13:19


          Update sdk/src/types/block/context_input/block_issuance_credit.rs

4e1e22c

Co-authored-by: Alexandcoats <[email protected]>

DaughterOfMars approved these changes

View reviewed changes

Thoralf-M approved these changes

View reviewed changes

kwek20 approved these changes

View reviewed changes

DaughterOfMars requested a review from qrayven

August 2, 2023 15:58

kwek20 mentioned this pull request

Feat/2.0: Transaction essence #988

Closed

qrayven approved these changes

View reviewed changes

abdulmth merged commit 0419ade into iotaledger:2.0

19 checks passed

This was referenced Aug 3, 2023

Add CommitmentInput - rust #901

Closed

Add BlockIssuanceCreditInput - rust #906

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Thoralf-M Thoralf-M approved these changes

qrayven qrayven approved these changes

DaughterOfMars DaughterOfMars approved these changes

kwek20 kwek20 approved these changes

thibault-martinez thibault-martinez left review comments

Labels

None yet