Feat/cli: added mnemonic gen from console only #983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not 2.0? |
|
oh :D |
kwek20
force-pushed
the
feat/cli/mnemonic-no-interact
branch
from
b67d130
to
6ef9bb3
Compare
kwek20
force-pushed
the
feat/cli/mnemonic-no-interact
branch
from
6ef9bb3
to
301f39f
Compare
added 2 commits
August 1, 2023 15:18
Thoralf-M
previously approved these changes
Aug 2, 2023
Thoralf-M
approved these changes
Aug 2, 2023
DaughterOfMars
approved these changes
Aug 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Allows getting mnemonic through just command line args
Links to any relevant issues
fixes #652
Type of change
How the change has been tested
Test cases:
./wallet mnemonic --output-stdout no-> Write to default file DO WE WANT THIS OR BACK TO USER CHOICE./wallet mnemonic --output-stdout yes-> Write to console./wallet mnemonic --output-stdout-> Write to console./wallet mnemonic --output-file-name filename.txt-> Writes to file./wallet mnemonic --output-file-name filename.txt --output-stdout-> Writes to file and console./wallet mnemonic-> Prompts user