-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Prevent webpack loading bindings when importing UTXOInput type #990
fix: Prevent webpack loading bindings when importing UTXOInput type #990
Conversation
…ts UtxoInput from outputId without callUtilsMethod.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is the right approach
… bindings loading when using type UTXOInput)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is okay?
I think It's ok because this is technically the only place we import |
Description of change
UTXOInput#fromOutputId
static function tolib/index.ts
to be attached dynamically.Prevents webpack loading bindings when just importing UTXOInput type.
Links to any relevant issues
Be sure to reference any related issues by adding
fixes #issue_number
.Type of change
Choose a type of change, and delete any options that are not relevant.
How the change has been tested
Tested the static function manually with some outputId cases.
Change checklist
Tick the boxes that are relevant to your changes, and delete any items that are not.