-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Cross Chain marketplace partIII #1668
Conversation
Signed-off-by: salaheldinsoliman <[email protected]>
Signed-off-by: salaheldinsoliman <[email protected]>
Signed-off-by: salaheldinsoliman <[email protected]>
This pull request has been deployed to Vercel. Latest commit: 0c8e4af ✅ Preview: https://iota-wiki-oc205c9g0-iota1.vercel.app |
docs/build/isc/v1.3/docs/tutorials/cross-chain-nft-marketplace-part-3.md
Outdated
Show resolved
Hide resolved
docs/build/isc/v1.3/docs/tutorials/cross-chain-nft-marketplace-part-3.md
Outdated
Show resolved
Hide resolved
docs/build/isc/v1.3/docs/tutorials/cross-chain-nft-marketplace-part-3.md
Outdated
Show resolved
Hide resolved
docs/build/isc/v1.3/docs/tutorials/cross-chain-nft-marketplace-part-3.md
Outdated
Show resolved
Hide resolved
docs/build/isc/v1.3/docs/tutorials/cross-chain-nft-marketplace-part-3.md
Outdated
Show resolved
Hide resolved
docs/build/isc/v1.3/docs/tutorials/cross-chain-nft-marketplace-part-3.md
Outdated
Show resolved
Hide resolved
docs/build/isc/v1.3/docs/tutorials/cross-chain-nft-marketplace-part-3.md
Outdated
Show resolved
Hide resolved
docs/build/isc/v1.3/docs/tutorials/cross-chain-nft-marketplace-part-3.md
Outdated
Show resolved
Hide resolved
docs/build/isc/v1.3/docs/tutorials/cross-chain-nft-marketplace-part-3.md
Outdated
Show resolved
Hide resolved
docs/build/isc/v1.3/docs/tutorials/cross-chain-nft-marketplace-part-3.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Lucas Tortora <[email protected]>
Signed-off-by: salaheldinsoliman <[email protected]>
Co-authored-by: Lucas Tortora <[email protected]>
docs/build/isc/v1.3/docs/tutorials/cross-chain-nft-marketplace-part-3.md
Show resolved
Hide resolved
``` | ||
|
||
|
||
## Scripts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the scripts section, we could also implement a command to verify the deployed contracts, wdyt?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That would be a good addition yes, but I think it is out of scope for this tutorial.
We would need the APIs for ShimmerEVM and BNBTestnet blockexplorers, and add some extra config to hardhat.config.js
.
What would be more suitable is adding this part later on, WDYT?
@salaheldinsoliman , are there any blockers on this? It'd be nice to publish the last part of the series :) |
@vivekjain23 Can you please approve this If you don't have further comments? thanks! |
Description of change
Part III of the tutorial, finally
Links to any relevant issues
#1663
Type of change
Change checklist
Tick the boxes that are relevant to your changes, and delete any items that are not.