Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Cross Chain marketplace partIII #1668

Merged
merged 6 commits into from
Sep 5, 2024

Conversation

salaheldinsoliman
Copy link
Contributor

@salaheldinsoliman salaheldinsoliman commented Aug 14, 2024

Description of change

Part III of the tutorial, finally

Links to any relevant issues

#1663

Type of change

  • Documentation Enhancement

Change checklist

Tick the boxes that are relevant to your changes, and delete any items that are not.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own changes
  • I have made sure that added/changed links still work
  • I have commented my code, particularly in hard-to-understand areas

Signed-off-by: salaheldinsoliman <[email protected]>
Signed-off-by: salaheldinsoliman <[email protected]>
Signed-off-by: salaheldinsoliman <[email protected]>
@salaheldinsoliman salaheldinsoliman marked this pull request as ready for review August 14, 2024 14:11
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 0c8e4af

✅ Preview: https://iota-wiki-oc205c9g0-iota1.vercel.app

salaheldinsoliman and others added 3 commits August 15, 2024 02:10
Signed-off-by: salaheldinsoliman <[email protected]>
```


## Scripts
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the scripts section, we could also implement a command to verify the deployed contracts, wdyt?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would be a good addition yes, but I think it is out of scope for this tutorial.
We would need the APIs for ShimmerEVM and BNBTestnet blockexplorers, and add some extra config to hardhat.config.js.
What would be more suitable is adding this part later on, WDYT?

@lucas-tortora
Copy link
Collaborator

@salaheldinsoliman , are there any blockers on this? It'd be nice to publish the last part of the series :)

@salaheldinsoliman
Copy link
Contributor Author

@vivekjain23 Can you please approve this If you don't have further comments? thanks!

@salaheldinsoliman salaheldinsoliman merged commit 581e38c into main Sep 5, 2024
9 checks passed
@salaheldinsoliman salaheldinsoliman deleted the feat/cross-chain-tutorial-partIII branch September 5, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants