feat(sui-genesis-builder): migrate Alias Outputs #163

PhilippGackstatter · 2024-05-03T15:18:58Z

Description of change

Implements the Move models in Rust for the migration of the Alias Output.

Changes to the Alias Move model:

Make attach_alias method public (was test-only before). This is needed so we can easily attach the Alias to the AliasOutput from a PTB, since we cannot pass alias_output.id as an argument to dynamic_object_field::add directly.
Make State Controller non-optional. A state controller is always present in the stardust model, so imho it does not make sense to make it Option<SuiAddress> in the move code, unless I missed the argument for it.

Links to any relevant issues

fixes issue #154.

Type of change

Choose a type of change, and delete any options that are not relevant.

Enhancement (a non-breaking change which adds functionality)

How the change has been tested

Added a migration test. More to be added for native tokens and in case the alias id is zeroed.

Change checklist

Tick the boxes that are relevant to your changes, and delete any items that are not.

I have followed the contribution guidelines for this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
I have added tests that prove my fix is effective or that my feature works
I have checked that new and existing unit tests pass locally with my changes

While creating foundries now maps the `(ObjectID, TypeOrigin)` to the `TokenId`.

…reate_basic_objects

crates/sui-genesis-builder/src/stardust/migration.rs

…utor::create_basic_objects

…n::Executor::create_basic_objects

…igration::Executor::create_basic_objects

…outputs

Co-authored-by: Philipp Gackstatter <[email protected]>

…outputs

crates/sui-genesis-builder/src/stardust/types/address.rs

crates/sui-genesis-builder/src/stardust/types/alias.rs

…outputs

miker83z

Great PR, it follows almost perfectly the assumed design!

I just signaled a major issue related to the security of generating ObjectIds + some small issues.

crates/sui-genesis-builder/src/stardust/types/snapshot.rs

crates/sui-genesis-builder/src/stardust/types/alias.rs

crates/sui-genesis-builder/src/stardust/migration.rs

crates/sui-genesis-builder/src/stardust/types/alias.rs

crates/sui-genesis-builder/src/stardust/migration.rs

…outputs

crates/sui-genesis-builder/tests/migrate_alias.rs

* feat(sui-genesis-builder): store TypeOrigin of native tokens While creating foundries now maps the `(ObjectID, TypeOrigin)` to the `TokenId`. * refactor(sui-genesis-builder): split stardust::types module * feat(sui-genesis-builder): add unlock types * feat(sui-genesis-builder): add BasicOutput type * refactor(sui-genesis-builder): use OutputHeader while creating outputs * feat(sui-genesis-builder): implement stardust::migration::Executor::create_basic_objects * fixup! feat(sui-genesis-builder): implement stardust::migration::Executor::create_basic_objects * fixup! fixup! feat(sui-genesis-builder): implement stardust::migration::Executor::create_basic_objects * feat(sui-genesis-builder): fix native-token object ids during migration * fixup! fixup! fixup! feat(sui-genesis-builder): implement stardust::migration::Executor::create_basic_objects * fix(sui-genesis-builder): correct BasicOutput::type_ module and name Co-authored-by: Philipp Gackstatter <[email protected]> * fix(sui-genesis-builder): load packages and input objects correctly * fix(sui-genesis-builder): dummy transfer Bag object * Implement move data model in Rust * Execute alias creation transaction * Fix dependencies during PTB execution * Fix alias tags, extend test * Add TODO for dynamic object field * Expose `attach_alias` function * Fix outstanding alias migration TODOs * Prettify alias migration test * `cargo fmt` the genesis builder * Make state controller non-optional * Move alias migration test to separate file * Cleanup alias migration test * Add zeroized check and simplify match statement * Add non-zeroed alias id test * Use to_genesis_object approach * Use fresh_id as the alias output ID * Compute version of aliases via `lamport_timestamp` * Move crate-level migration test to module --------- Co-authored-by: Konstantinos Demartinos <[email protected]>

kodemartin added 6 commits May 1, 2024 18:45

feat(sui-genesis-builder): store TypeOrigin of native tokens

1385342

While creating foundries now maps the `(ObjectID, TypeOrigin)` to the `TokenId`.

refactor(sui-genesis-builder): split stardust::types module

bf229ca

feat(sui-genesis-builder): add unlock types

28246e8

feat(sui-genesis-builder): add BasicOutput type

073ed9a

refactor(sui-genesis-builder): use OutputHeader while creating outputs

87337aa

feat(sui-genesis-builder): implement stardust::migration::Executor::c…

3c1e1de

…reate_basic_objects

PhilippGackstatter changed the base branch from develop to 112-migrate-basic-outputs May 3, 2024 15:19

kodemartin reviewed May 9, 2024

View reviewed changes

crates/sui-genesis-builder/src/stardust/migration.rs Outdated Show resolved Hide resolved

crates/sui-genesis-builder/src/stardust/migration.rs Outdated Show resolved Hide resolved

kodemartin reviewed May 9, 2024

View reviewed changes

crates/sui-genesis-builder/src/stardust/migration.rs Outdated Show resolved Hide resolved

kodemartin reviewed May 9, 2024

View reviewed changes

crates/sui-genesis-builder/src/stardust/migration.rs Outdated Show resolved Hide resolved

fixup! feat(sui-genesis-builder): implement stardust::migration::Exec…

091f125

…utor::create_basic_objects

miker83z changed the title ~~Migrate Alias Outputs~~ feat(sui-genesis-builder): migrate Alias Outputs May 10, 2024

kodemartin and others added 5 commits May 10, 2024 16:48

fixup! fixup! feat(sui-genesis-builder): implement stardust::migratio…

4b0a400

…n::Executor::create_basic_objects

feat(sui-genesis-builder): fix native-token object ids during migration

d7776ad

fixup! fixup! fixup! feat(sui-genesis-builder): implement stardust::m…

c9aa74b

…igration::Executor::create_basic_objects

Merge remote-tracking branch 'origin/develop' into 112-migrate-basic-…

fbe3f6b

…outputs

fix(sui-genesis-builder): correct BasicOutput::type_ module and name

f22acfe

Co-authored-by: Philipp Gackstatter <[email protected]>

PhilippGackstatter mentioned this pull request May 13, 2024

feat(sui-genesis-builder): implement creation of basic outputs #159

Merged

6 tasks

kodemartin and others added 10 commits May 13, 2024 17:38

fix(sui-genesis-builder): load packages and input objects correctly

c55f70c

fix(sui-genesis-builder): dummy transfer Bag object

85de8d6

Implement move data model in Rust

3a366b1

Execute alias creation transaction

822b02e

Fix dependencies during PTB execution

8f38ec7

Fix alias tags, extend test

9c2594c

Add TODO for dynamic object field

c4a13fb

Expose attach_alias function

b7b1b5e

Fix outstanding alias migration TODOs

a9285f6

Prettify alias migration test

e60e613

PhilippGackstatter force-pushed the 154-migrate-alias-outputs branch from 5b6fcac to e60e613 Compare May 14, 2024 12:19

cargo fmt the genesis builder

c72792e

miker83z added the sc-platform Issues related to the Smart Contract Platform group. label May 14, 2024

miker83z added this to the L1SC/IOTA-Framework milestone May 14, 2024

PhilippGackstatter added 3 commits May 15, 2024 08:40

Merge remote-tracking branch 'origin/develop' into 154-migrate-alias-…

f5457a5

…outputs

Move alias migration test to separate file

bf5134a

Cleanup alias migration test

ec92dc6

PhilippGackstatter marked this pull request as ready for review May 15, 2024 07:35

PhilippGackstatter requested review from kodemartin and miker83z May 15, 2024 07:36

Thoralf-M reviewed May 15, 2024

View reviewed changes

crates/sui-genesis-builder/src/stardust/types/address.rs Outdated Show resolved Hide resolved

Thoralf-M reviewed May 15, 2024

View reviewed changes

crates/sui-genesis-builder/src/stardust/types/alias.rs Outdated Show resolved Hide resolved

PhilippGackstatter added 3 commits May 15, 2024 12:29

Add zeroized check and simplify match statement

c846e3a

Merge remote-tracking branch 'origin/develop' into 154-migrate-alias-…

71ea94d

…outputs

Add non-zeroed alias id test

c87dd6b

miker83z requested changes May 15, 2024

View reviewed changes

PhilippGackstatter added 5 commits May 16, 2024 10:32

Use to_genesis_object approach

436601b

Use fresh_id as the alias output ID

7799f2d

Merge remote-tracking branch 'origin/develop' into 154-migrate-alias-…

2fd0d93

…outputs

Compute version of aliases via lamport_timestamp

56db801

Merge remote-tracking branch 'origin/develop' into 154-migrate-alias-…

9820678

…outputs

kodemartin requested changes May 16, 2024

View reviewed changes

crates/sui-genesis-builder/tests/migrate_alias.rs Outdated Show resolved Hide resolved

Move crate-level migration test to module

01a4ed8

miker83z approved these changes May 16, 2024

View reviewed changes

kodemartin approved these changes May 16, 2024

View reviewed changes

PhilippGackstatter merged commit 978bbb7 into develop May 16, 2024
17 of 35 checks passed

PhilippGackstatter deleted the 154-migrate-alias-outputs branch May 16, 2024 13:14

PhilippGackstatter mentioned this pull request May 16, 2024

[Task (L1SC)]: Trasformation Logic for Alias Outputs #154

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(sui-genesis-builder): migrate Alias Outputs #163

feat(sui-genesis-builder): migrate Alias Outputs #163

PhilippGackstatter commented May 3, 2024 •

edited

Loading

miker83z left a comment

feat(sui-genesis-builder): migrate Alias Outputs #163

feat(sui-genesis-builder): migrate Alias Outputs #163

Conversation

PhilippGackstatter commented May 3, 2024 • edited Loading

Description of change

Links to any relevant issues

Type of change

How the change has been tested

Change checklist

miker83z left a comment

Choose a reason for hiding this comment

PhilippGackstatter commented May 3, 2024 •

edited

Loading