docs: Proofread Standards docs #1668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhilippGackstatter
changed the title
…tandards-docs-updates
…tandards-docs-updates
|
✅ Vercel Preview Deployment is ready! |
|
✅ Vercel Preview Deployment is ready! |
|
✅ Vercel Preview Deployment is ready! |
lucas-tortora
approved these changes
Aug 9, 2024
Okay, I think I did what you wanted, but not 100% sure I understood correctly 😅 |
Thoralf-M
approved these changes
Aug 12, 2024
valeriyr
approved these changes
Aug 12, 2024
There was a problem hiding this comment.
@PhilippGackstatter well done! Just left several minor comments.
|
✅ Vercel Preview Deployment is ready! |
Dr-Electron
requested changes
Aug 12, 2024
Co-authored-by: Dr-Electron <[email protected]>
|
✅ Vercel Preview Deployment is ready! |
|
✅ Vercel Preview Deployment is ready! |
Dr-Electron
approved these changes
Aug 13, 2024
bingyanglin
pushed a commit
that referenced
this pull request
Aug 19, 2024
* fix(docs): Typos in Standards section * fix(docs): Fix typos and broken links in coin docs * fix(docs): Typos in CoinManager doc * feat(docs): Add missing PTBs to kiosk docs * fix(docs): Typos in kiosk apps * fix(docs): Fix typos and consistency * fix(docs): Convert tabs to spaces * fix(docs): Typos in wallet standard * fix(docs): JavaScript examples * fix(docs): Make Move examples syntactically correct * fix(docs): Put overview on Standards header * fix(docs): update link to Standards in developer documentation * Update docs/content/sidebars/developer.js Co-authored-by: Dr-Electron <[email protected]> * fix(docs): Auto generate standards overview * fix(docs): More move warning fixes * fix(docs): Use `programmable_move_call` instead of command --------- Co-authored-by: Thibault Martinez <[email protected]> Co-authored-by: Dr-Electron <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Proofread Standards section in the docs.
@iota/wallet-standardis a package that will be published, so the Wallet Standard page should be correct as-is once the wiki goes public.structdefinition examples in Move were madepublicsince structs must always be public and the examples should be syntactically correct. Unnecessary imports were also removed and some occurrences were rewritten to method-style syntax.Links to any relevant issues
fixes #1293