Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(explorer): improve enums coding conventions #181

Merged
merged 5 commits into from
May 15, 2024

Conversation

evavirseda
Copy link
Contributor

Description of change

Please write a summary of your changes and why you made them.

Links to any relevant issues

fixes issue #179

Type of change

Choose a type of change, and delete any options that are not relevant.

  • Bug fix (a non-breaking change which fixes an issue)
  • Enhancement (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Fix

How the change has been tested

Describe the tests that you ran to verify your changes.

Make sure to provide instructions for the maintainer as well as any relevant configurations.

Change checklist

Tick the boxes that are relevant to your changes, and delete any items that are not.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes

@evavirseda evavirseda requested review from begonaalvarezd and VmMad May 9, 2024 11:56
@evavirseda evavirseda changed the base branch from tooling to feat/bring-back-explorer May 9, 2024 12:48
@evavirseda evavirseda changed the title feat: improve enums coding conventions feat (explorer): improve enums coding conventions May 9, 2024
@evavirseda evavirseda changed the title feat (explorer): improve enums coding conventions [tooling explorer]: improve enums coding conventions May 9, 2024
@evavirseda evavirseda changed the title [tooling explorer]: improve enums coding conventions feat(tooling explorer): improve enums coding conventions May 10, 2024
@evavirseda evavirseda changed the title feat(tooling explorer): improve enums coding conventions feat (explorer): improve enums coding conventions May 10, 2024
Base automatically changed from feat/bring-back-explorer to tooling May 15, 2024 16:29
@begonaalvarezd begonaalvarezd added the tooling Issues related to the Tooling team label May 15, 2024
@begonaalvarezd begonaalvarezd changed the title feat (explorer): improve enums coding conventions refactor(explorer): improve enums coding conventions May 15, 2024
@begonaalvarezd begonaalvarezd merged commit 8ee8ed0 into tooling May 15, 2024
33 of 38 checks passed
@begonaalvarezd begonaalvarezd deleted the feat/improve-enums-coding-convention branch May 15, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tooling Issues related to the Tooling team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task (Tooling)]: Cleanup explorer codebase: Improve enums coding conventions
3 participants