Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(wallet,wallet-dashboard): fix total stake/unstake amount in timelocks transaction summary #4824

Merged
merged 16 commits into from
Jan 23, 2025
Merged

fix(wallet,wallet-dashboard): fix total stake/unstake amount in timelocks transaction summary #4824

merged 16 commits into from
Jan 23, 2025

Conversation

evavirseda
Copy link
Contributor

Description of change

Please write a summary of your changes and why you made them.

Links to any relevant issues

fixes #4779

Type of change

Choose a type of change, and delete any options that are not relevant.

  • Bug fix (a non-breaking change which fixes an issue)
  • Enhancement (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Fix

How the change has been tested

Describe the tests that you ran to verify your changes.

Make sure to provide instructions for the maintainer as well as any relevant configurations.

Change checklist

Tick the boxes that are relevant to your changes, and delete any items that are not.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes

@evavirseda evavirseda requested a review from a team as a code owner January 16, 2025 10:15
@vercel Vercel
Copy link

vercel bot commented Jan 16, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
apps-backend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 23, 2025 11:53am
rebased-explorer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 23, 2025 11:53am
wallet-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 23, 2025 11:53am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
apps-ui-kit ⬜️ Ignored (Inspect) Visit Preview Jan 23, 2025 11:53am

@evavirseda evavirseda self-assigned this Jan 16, 2025
@github-actions github-actions bot added wallet Issues related to the IOTA Wallet wallet-dashboard Issues related to the Wallet Dashboard dApp labels Jan 16, 2025
@iota-ci iota-ci added the tooling Issues related to the Tooling team label Jan 16, 2025
@begonaalvarezd begonaalvarezd changed the title feat(wallet/wallet-dashboard): fix total stake/unstake amount in timelocks transaction summary fix(wallet,wallet-dashboard): fix total stake/unstake amount in timelocks transaction summary Jan 16, 2025
cpl121
cpl121 requested changes Jan 21, 2025
View reviewed changes
Copy link
Member

@cpl121 cpl121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The unstake amount is not adding up well
image

apps/core/src/utils/stake/getTransactionAmountForTimelocked.ts Outdated Show resolved Hide resolved
@evavirseda evavirseda requested a review from cpl121 January 22, 2025 10:20
cpl121
cpl121 requested changes Jan 23, 2025
View reviewed changes
Copy link
Member

@cpl121 cpl121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just minimal comments 🙏🏼

apps/core/src/utils/stake/getUnstakeDetailsFromEvents.ts Outdated Show resolved Hide resolved
apps/core/src/utils/stake/getUnstakeDetailsFromEvents.ts Outdated Show resolved Hide resolved
apps/core/src/utils/stake/getTransactionAmountForTimelocked.ts Outdated Show resolved Hide resolved
@evavirseda evavirseda requested a review from cpl121 January 23, 2025 11:49
@cpl121 cpl121 merged commit a85d8cd into develop Jan 23, 2025
32 checks passed
@cpl121 cpl121 deleted the tooling/fix-total-stake-unstake-amount-in-timelocks-tx branch January 23, 2025 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpl121 cpl121 cpl121 approved these changes

@begonaalvarezd begonaalvarezd begonaalvarezd approved these changes

Assignees

@evavirseda evavirseda

Labels
tooling Issues related to the Tooling team wallet Issues related to the IOTA Wallet wallet-dashboard Issues related to the Wallet Dashboard dApp
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix total stake/unstake amount in timelocks transaction summary
4 participants
@evavirseda @begonaalvarezd @cpl121 @iota-ci