chore(cli): Improve error message for attempting genesis with non-empty config dir #4987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
iota-ci
added
dev-tools
Thoralf-M
approved these changes
Jan 30, 2025
crates/iota/src/iota_commands.rs
Outdated
| @@ -727,7 +727,8 @@ async fn start( | |||
| remote_migration_snapshots, | |||
| delegator, | |||
| ) | |||
| .await?; | |||
| .await | |||
| .map_err(|_| anyhow!("Cannot run genesis with non-empty IOTA config directory: {}.\n\nIf you are trying to run a local network without persisting the data (so a new genesis that is randomly generated and will not be saved once the network is shut down), use --force-regenesis flag.\nIf you are trying to persist the network data and start from a new genesis, use iota genesis --help to see how to generate a new genesis.", config.display()))?; | |||
There was a problem hiding this comment.
Can we format this pls?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Ports the error message of MystenLabs/sui#19487
How the change was tested
Ran
iota startwith a non-empty config directory by renamingnetwork.yamlto something else, which triggers that code path.Links to any relevant issues
fixes #4926