Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(*): Fix many more typos #5075

Merged
merged 17 commits into from
Feb 5, 2025
Merged

chore(*): Fix many more typos #5075

merged 17 commits into from
Feb 5, 2025
+223 −218

Conversation

DaughterOfMars
Copy link
Contributor

Description

This PR updates the typos config with better regex and removes some excess configs, as well as fixing the resulting typos that were found.

@DaughterOfMars DaughterOfMars requested review from a team and muXxer as code owners January 28, 2025 19:35
@vercel Vercel
Copy link

vercel bot commented Jan 28, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
apps-backend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 5, 2025 4:33pm
apps-ui-kit ✅ Ready (Inspect) Visit Preview Feb 5, 2025 4:33pm
rebased-explorer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 5, 2025 4:33pm
wallet-dashboard ✅ Ready (Inspect) Visit Preview Feb 5, 2025 4:33pm

@iota-ci iota-ci added dev-tools Issues related to the Developer Tools Team sc-platform Issues related to the Smart Contract Platform group. labels Jan 28, 2025
@github-actions github-actions bot added documentation Improvements or additions to documentation apps-ui-kit Issues related to the Apps UI Kit wallet Issues related to the IOTA Wallet ts-sdk Issues related to the TS SDK explorer Issues related to the Explorer wallet-dashboard Issues related to the Wallet Dashboard dApp apps-backend Issues related to the Apps Backend and removed sc-platform Issues related to the Smart Contract Platform group. dev-tools Issues related to the Developer Tools Team labels Jan 28, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 28, 2025 •
edited
Loading

⚠️ 🦋 Changesets Warning: This PR has changes to public npm packages, but does not contain a changeset. You can create a changeset easily by running pnpm changeset in the root of the IOTA repo, and following the prompts. If your change does not need a changeset (e.g. a documentation-only change), you can ignore this message. This warning will be removed when a changeset is added to this pull request.

Learn more about Changesets.

@github-actions GitHub Actions
Copy link
Contributor

✅ Vercel Preview Deployment is ready!

View Preview

@DaughterOfMars
Copy link
Contributor Author

I would appreciate it if someone would advice me on what kind of version bumps should be in effect after these changes

@DaughterOfMars
new typos
Loading
Loading status checks…
09c3bd8
@github-actions GitHub Actions
Copy link
Contributor

✅ Vercel Preview Deployment is ready!

View Preview

@DaughterOfMars
Update tests
Loading
Loading status checks…
a44ecff
@github-actions GitHub Actions
Copy link
Contributor

✅ Vercel Preview Deployment is ready!

View Preview

thibault-martinez
thibault-martinez reviewed Feb 3, 2025
View reviewed changes
thibault-martinez
thibault-martinez reviewed Feb 3, 2025
View reviewed changes
thibault-martinez
thibault-martinez requested changes Feb 3, 2025
View reviewed changes
crates/iota/src/client_ptb/parser.rs Outdated
Ok(sp.wrap(ParsedPTBCommand::TransferObjects(
transfer_froms,
transfer_from,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I disagree, it can't be transfers_x, these are the multiple objects of a single Transfer

thibault-martinez
thibault-martinez reviewed Feb 4, 2025
View reviewed changes
@DaughterOfMars
review
Loading
Loading status checks…
080c6a8
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 4, 2025

✅ Vercel Preview Deployment is ready!

View Preview

@DaughterOfMars
renames
Loading
Loading status checks…
70d721a
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 5, 2025

✅ Vercel Preview Deployment is ready!

View Preview

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 5, 2025

✅ Vercel Preview Deployment is ready!

View Preview

@DaughterOfMars DaughterOfMars merged commit ae815a9 into develop Feb 5, 2025
42 checks passed
@DaughterOfMars DaughterOfMars deleted the dev-tools/more-typos branch February 5, 2025 17:04
lucas-tortora pushed a commit that referenced this pull request Feb 11, 2025
@DaughterOfMars @thibault-martinez
chore(*): Fix many more typos (#5075)
b2a9668 
* chore(*): Fix many more typos

* more fixes

* fmt

* tweaks

* actual hex

* hex again

* 😤

* fix exp files

* fix one more

* new typos

* Update tests

* review

* renames

---------

Co-authored-by: Thibault Martinez <[email protected]>
Signed-off-by: Lucas Tortora <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomxey tomxey

@Thoralf-M Thoralf-M

@lucas-tortora lucas-tortora

@valeriyr valeriyr

@thibault-martinez thibault-martinez

@begonaalvarezd begonaalvarezd

@piotrm50 piotrm50

@kodemartin kodemartin

@muXxer muXxer

@Alex6323 Alex6323

@Dr-Electron Dr-Electron

Assignees
No one assigned
Labels
apps-backend Issues related to the Apps Backend apps-ui-kit Issues related to the Apps UI Kit dev-tools Issues related to the Developer Tools Team documentation Improvements or additions to documentation explorer Issues related to the Explorer sc-platform Issues related to the Smart Contract Platform group. ts-sdk Issues related to the TS SDK wallet Issues related to the IOTA Wallet wallet-dashboard Issues related to the Wallet Dashboard dApp
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet