Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(indexer): Split object version ingestion #5113

Merged
merged 3 commits into from
Feb 5, 2025
Merged

refactor(indexer): Split object version ingestion #5113

merged 3 commits into from
Feb 5, 2025

Conversation

tomxey
Copy link
Contributor

@tomxey tomxey commented Jan 31, 2025 •
edited
Loading

Description of change

Split object version ingestion as a separate step from the object history ingestion.

Pulled from: MystenLabs/sui#19104

Links to any relevant issues

Fixes #5112

Type of change

Refactor

How the change has been tested

cargo test -j2 --package=iota-indexer --profile=simulator --features=shared_test_runtime

Change checklist

Tick the boxes that are relevant to your changes, and delete any items that are not.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes

@tomxey tomxey self-assigned this Jan 31, 2025
@vercel Vercel
Copy link

vercel bot commented Jan 31, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
apps-backend ⬜️ Ignored (Inspect) Visit Preview Feb 4, 2025 9:41am
apps-ui-kit ⬜️ Ignored (Inspect) Visit Preview Feb 4, 2025 9:41am
rebased-explorer ⬜️ Ignored (Inspect) Visit Preview Feb 4, 2025 9:41am
wallet-dashboard ⬜️ Ignored (Inspect) Visit Preview Feb 4, 2025 9:41am

@iota-ci iota-ci added infrastructure Issues related to the Infrastructure Team sc-platform Issues related to the Smart Contract Platform group. labels Jan 31, 2025
@tomxey tomxey marked this pull request as ready for review January 31, 2025 12:19
@tomxey tomxey requested a review from a team as a code owner January 31, 2025 12:19
kodemartin
kodemartin approved these changes Feb 3, 2025
View reviewed changes
Copy link
Contributor

@kodemartin kodemartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with minor comments

crates/iota-indexer/src/handlers/checkpoint_handler.rs Outdated Show resolved Hide resolved
crates/iota-indexer/src/handlers/checkpoint_handler.rs Outdated Show resolved Hide resolved
crates/iota-indexer/src/store/pg_indexer_store.rs Outdated Show resolved Hide resolved
sergiupopescu199
sergiupopescu199 approved these changes Feb 4, 2025
View reviewed changes
Copy link
Contributor

@sergiupopescu199 sergiupopescu199 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🏄‍♂️

@tomxey tomxey merged commit 20e230e into develop Feb 5, 2025
41 checks passed
@tomxey tomxey deleted the sc-platform/split-object-version-ingestion branch February 5, 2025 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kodemartin kodemartin kodemartin approved these changes

@sergiupopescu199 sergiupopescu199 sergiupopescu199 approved these changes

@samuel-rufi samuel-rufi Awaiting requested review from samuel-rufi

Assignees

@tomxey tomxey

Labels
infrastructure Issues related to the Infrastructure Team sc-platform Issues related to the Smart Contract Platform group.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

indexer: split object version ingestion for perf {"side-effects": "medium", "type": "optimization"}
4 participants
@tomxey @kodemartin @sergiupopescu199 @iota-ci