Add external address to full node setup #5117
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 4 Skipped Deployments
|
github-actions
bot
added
the
documentation
setups/fullnode/docker/README.md
Outdated
|
|
||
| #### Devnet | ||
|
|
||
| ```yaml | ||
| p2p-config: |
There was a problem hiding this comment.
imho not a good idea to remove the p2p-config because people won't understand how the yaml should be indented
There was a problem hiding this comment.
Yeah I thought about that too. I questioned what will be more likely. People not copying it correctly or people duplicating the p2p-config 😅.
There was a problem hiding this comment.
Maybe remove it and add a small note about indentation?
There was a problem hiding this comment.
Tbh that is even worst. Indenting yaml is complicated enough. When you copy without having the p2p-config container you have no clue how many white-spaces you need in front. Displaying the p2p-config allows you to compare to your configuration.
There was a problem hiding this comment.
Tbf if people are not smart enough to do a copy and paste I'm wondering if they should operate a node 
But I will re-add it 👍
setups/fullnode/docker/README.md
Outdated
|
|
||
| #### Devnet | ||
|
|
||
| ```yaml | ||
| p2p-config: |
There was a problem hiding this comment.
Maybe remove it and add a small note about indentation?
Description of change
Added external address to full node setup
Links to any relevant issues
Fixes #4887.
Type of change
Change checklist