fix: Avoid free NULL pointer of bundle (#7)

Avoid assigning NULL when pointer of pointer, bundle is NULL. Co-authored-by: Sam Chen <[email protected]>
iotaledger · Jan 31, 2020 · 50aeee0 · 50aeee0
1 parent e97da0f
commit 50aeee0
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/common/model/bundle.c b/common/model/bundle.c
@@ -95,11 +95,17 @@ static retcode_t validate_signatures(bundle_transactions_t const *const bundle,
 
 void bundle_transactions_new(bundle_transactions_t **const bundle) { utarray_new(*bundle, &bundle_transactions_icd); }
 
-void bundle_transactions_free(bundle_transactions_t **const bundle) {
+retcode_t bundle_transactions_free(bundle_transactions_t **const bundle) {
+  if (!bundle || !*bundle) {
+    return RC_NULL_PARAM;
+  }
+
   if (bundle && *bundle) {
     utarray_free(*bundle);
   }
   *bundle = NULL;
+
+  return RC_OK;
 }
 
 retcode_t bundle_transactions_add(bundle_transactions_t *const bundle, iota_transaction_t const *const transaction) {

diff --git a/common/model/bundle.h b/common/model/bundle.h
@@ -62,8 +62,9 @@ void bundle_transactions_new(bundle_transactions_t **const bundle);
  * @brief Frees a bundle object.
  *
  * @param[in] bundle A bundle object.
+ * @return #retcode_t
  */
-void bundle_transactions_free(bundle_transactions_t **const bundle);
+retcode_t bundle_transactions_free(bundle_transactions_t **const bundle);
 
 /**
  * @brief Adds a transaction to the bundle.