Updated bundle and address value counting to add exact

iotaledger · Sep 23, 2017 · 67cf05a · 67cf05a
1 parent 9fb9198
commit 67cf05a
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/src/main/java/com/iota/iri/BundleValidator.java b/src/main/java/com/iota/iri/BundleValidator.java
@@ -39,8 +39,13 @@ public static List<List<TransactionViewModel>> validate(Tangle tangle, Hash hash
 
                     instanceTransactionViewModels.add(transactionViewModel);
 
-                    if (transactionViewModel.getCurrentIndex() != i || transactionViewModel.lastIndex() != lastIndex
-                            || ((bundleValue += transactionViewModel.value()) < -TransactionViewModel.SUPPLY || bundleValue > TransactionViewModel.SUPPLY)) {
+
+                    if (
+                            transactionViewModel.getCurrentIndex() != i
+                            || transactionViewModel.lastIndex() != lastIndex
+                            || ((bundleValue = Math.addExact(bundleValue, transactionViewModel.value())) < -TransactionViewModel.SUPPLY
+                            || bundleValue > TransactionViewModel.SUPPLY)
+                            ) {
                         instanceTransactionViewModels.get(0).setValidity(tangle, -1);
                         break;
                     }

diff --git a/src/main/java/com/iota/iri/LedgerValidator.java b/src/main/java/com/iota/iri/LedgerValidator.java
@@ -116,7 +116,7 @@ private Map<Hash,Long> getLatestDiff(Hash tip, int latestSnapshotIndex, boolean
                                             final Hash address = bundleTransactionViewModel.getAddressHash();
                                             final Long value = state.get(address);
                                             state.put(address, value == null ? bundleTransactionViewModel.value()
-                                                    : (value + bundleTransactionViewModel.value()));
+                                                    : Math.addExact(value, bundleTransactionViewModel.value()));
                                         }
                                     }