Skip to content
This repository has been archived by the owner on Aug 23, 2020. It is now read-only.

Feature: Store pruned transaction hashes in a cuckoo filter #1417

Open
wants to merge 13 commits into
base: dev
Choose a base branch
from

Conversation

kwek20
Copy link
Contributor

@kwek20 kwek20 commented Apr 24, 2019

Description

We want to track pruned confirmed transaction hashes to a cuckoo filter before we delete them.
At the end of each pruning cycle we want to persist the cuckoo filter state in the db.

We will currently maintain 10 cuckoo filters maximum, once a new filter gets added (another pruning cycle)
the first gets deleted.
Each filter is maintained in the database by an index, and when restored from database, the lowest index will be first to get deleted.

Fixes # (issue)
#1370

Type of change

  • Enhancement (a non-breaking change which adds functionality)

How Has This Been Tested?

  • Unit tests added

Checklist:

  • My code follows the style guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@iotaledger iotaledger deleted a comment Apr 24, 2019
@iotaledger iotaledger deleted a comment Apr 24, 2019
@iotaledger iotaledger deleted a comment Apr 24, 2019
@iotaledger iotaledger deleted a comment Apr 24, 2019
@GalRogozinski
Copy link
Contributor

Need to properly prioritize the merging of this PR

@jakubcech jakubcech added C-Spent Addresses Deffered Will be addressed and merged in later versions. labels May 7, 2019
@iotaledger iotaledger deleted a comment May 14, 2019
@iotaledger iotaledger deleted a comment May 14, 2019
@iotaledger iotaledger deleted a comment May 14, 2019
@iotaledger iotaledger deleted a comment May 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
C-Spent Addresses Deffered Will be addressed and merged in later versions.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants