Skip to content
This repository has been archived by the owner on Aug 23, 2020. It is now read-only.

Fix: Fixes regression introduced through the bundle validator refactor #1588

Merged
merged 2 commits into from
Sep 2, 2019

Conversation

luca-moser
Copy link
Member

Description

Through a redundant break statement, the balance diff creating method did return before it actually computed any balance diff, leading to every applied milestone to not change any addresses.

Weird is that no unit or regression tests catched this. We should have a regression test which mutates addresses and then does a getBalances() call to check that the address really was mutated (I didn't check whether we already have such regression test).

Type of change

  • Bug fix (a non-breaking change which fixes an issue)

How Has This Been Tested?

Applied this patch to my localsnapshot/spent-addresses RocksDB PR and verified that the mutated balances were not zero anymore.

Checklist:

  • My code follows the style guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Copy link
Contributor

@GalRogozinski GalRogozinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GalRogozinski
Copy link
Contributor

Buildkite restarted now...
Once it passes this will be merged.

Since I see this as high priority then #1590 is also a priority

@GalRogozinski GalRogozinski merged commit b248dbd into iotaledger:dev Sep 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants