Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: macos notarization #114

Merged
merged 3 commits into from
Jan 9, 2024
Merged

fix: macos notarization #114

merged 3 commits into from
Jan 9, 2024

Conversation

cpl121
Copy link
Member

@cpl121 cpl121 commented Jan 9, 2024

Closes #113

Summary

See https://developer.apple.com/documentation/technotes/tn3147-migrating-to-the-latest-notarization-tool and iotaledger/firefly#7678

Changelog

Please write an accurate and concise changelog for your changes.

Relevant Issues

Please list any related issues (e.g. bug, task).

Type of Change

Please select any type below that is applicable to your changes, and delete those that are not.

  • Breaking - any change that would cause existing functionality to not work as expected
  • Chore - refactoring, build scripts or anything else that isn't user-facing
  • Docs - changes to the documentation
  • Fix - a change which fixes an issue
  • New - a change which implements a new feature
  • Update - a change which updates existing functionality

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

Checklist

Please tick all of the following boxes that are relevant to your changes, and delete those that are not.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@begonaalvarezd begonaalvarezd marked this pull request as ready for review January 9, 2024 18:49
Copy link
Member

@begonaalvarezd begonaalvarezd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@begonaalvarezd begonaalvarezd merged commit f9a3416 into main Jan 9, 2024
9 of 10 checks passed
@begonaalvarezd begonaalvarezd deleted the fix/macos-notarization branch January 9, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: FIx error in the mac CI
3 participants