Implement checkpoint Sync & Indexing #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # Cargo.lock # Cargo.toml # src/main.rs # src/models.rs # src/schema.rs
sergiupopescu199
force-pushed
the
infra/issue-2
branch
from
f32d0bd to
1a7c7e1
Compare
sergiupopescu199
force-pushed
the
infra/issue-2
branch
from
c9edcda to
766d478
Compare
tomxey
reviewed
Dec 10, 2024
sergiupopescu199
force-pushed
the
infra/issue-2
branch
from
cff6a7f to
0b00e2a
Compare
tomxey
reviewed
Dec 11, 2024
kodemartin
requested changes
Dec 11, 2024
There was a problem hiding this comment.
Hey @sergiupopescu199 looks good in general. Left a few suggestions/comments, nothing critical though.
kodemartin
reviewed
Dec 12, 2024
kodemartin
reviewed
Dec 12, 2024
There was a problem hiding this comment.
Hey @sergiupopescu199 thanks for the changes. Left a few more minor suggestions, plus another idea for a follow-up issue regarding atomic insertion of objects and their unlock conditions.
kodemartin
approved these changes
Dec 12, 2024
There was a problem hiding this comment.
Looks good @sergiupopescu199! Haven't tested it though.
Left a last minor suggestion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implement the checkpoint sync and indexing into SQLite using the
iota-data-ingestion-corecrate.Links to any relevant issues
Fixes #2
How the change has been tested
Start a local network which contains a stardust migration
cd iota/docker/pg-services-local docker compose up -d local-networkStart the indexer
check SQLite tables if any records are stored