Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Add key length limit for trie kvstore #2561

Merged
merged 1 commit into from
Jun 26, 2023
Merged

refactor: Add key length limit for trie kvstore #2561

merged 1 commit into from
Jun 26, 2023

Conversation

howjmay
Copy link
Member

@howjmay howjmay commented Jun 5, 2023 •
edited
Loading

closes #2492

@howjmay howjmay force-pushed the key-limit branch 4 times, most recently from 88f01d6 to 93806d1 Compare June 7, 2023 03:59
jorgemmsilva
jorgemmsilva approved these changes Jun 14, 2023
View reviewed changes
Copy link
Contributor

@jorgemmsilva jorgemmsilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good to me, just a question regarding the 256 value, how did we chose that number?

@howjmay howjmay marked this pull request as ready for review June 23, 2023 15:54
@howjmay howjmay merged commit e341999 into iotaledger:develop Jun 26, 2023
@howjmay howjmay deleted the key-limit branch June 26, 2023 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorgemmsilva jorgemmsilva jorgemmsilva approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set a hard cap to kvstore key length
2 participants
@howjmay @jorgemmsilva