-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add ledger, stronghold and keychain into cli #2655
Conversation
packages/cryptolib/keypair.go
Outdated
} | ||
|
||
func (k *KeyPair) Sign(addr iotago.Address, payload []byte) (iotago.Signature, error) { | ||
// TODO: Validate this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So... who is going to validate this? 🤣
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did! Seems to work fine. :D
err := keyChain.SetSeed(seed) | ||
log.Check(err) | ||
|
||
log.Printf("In memory seed saved in the keychain.\n") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
log.Printf("In memory seed saved in the keychain.\n") | |
log.Printf("In-memory seed saved in the keychain.\n") |
78fe729
to
6279e43
Compare
4f1aa72
to
f5a5294
Compare
7cd68b9
to
f98499a
Compare
0c06ae2
to
de45adb
Compare
6a6f0d9
to
299a1a2
Compare
After some weeks of working with this branch I didn't really have any major problems. Some notes tho:
|
ac86e4b
to
f119eea
Compare
…ir/config path setup
b3f0661
to
6f1d6bb
Compare
Description of change
Adds a more secure layer into the wasp-cli.
It is based on the wasp-wallet-sdk library
Which is based on the iota-sdk native library
This feature introduces Ledger and Stronghold wallet providers.
Alternatively, the user can choose to remain using the common seed - but it will now be stored in the OS Keychain instead of the
wasp-cli.json
. The seed will be loaded into a more secure encrypted in-memory vault at runtime.Starting from this version, each user is required to have the
iota_sdk
library next to thewasp-cli
. Prebuilt releases are available here and are shipped withwasp-cli
releases as well.Type of change
Choose a type of change, and delete any options that are not relevant.
How the change has been tested
The most delicate parts are in the two referenced dependencies.
The Go library has tests, which are to be found here
The Rust native lib does not have tests yet.