Remove unneeded error.h include from examples/cpp/KModRetExample.cc to allow build with musl libc #5105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
musl libc has no error.h, but luckily the include is not needed at all and can just be removed.
hhoffstaette
requested review from
drzaeus77,
goldshtn,
yonghong-song,
4ast,
brendangregg and
davemarchevsky
as code owners
dkruces
pushed a commit
to dkruces/bcc
that referenced
this pull request
Nov 28, 2024
…r#5105) musl libc has no error.h, but luckily the include is not needed at all and can just be removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
musl libc has no error.h, but luckily the include is not needed at all and can just be removed.
Previously reported in #4594 and more recently in Gentoo at https://bugs.gentoo.org/939453.