libbpf-tools: add cpu filter for hardirqs/softirqs #5107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZhangYet
requested review from
drzaeus77,
goldshtn,
yonghong-song,
4ast,
brendangregg and
davemarchevsky
as code owners
ekyooo
reviewed
Sep 27, 2024
ZhangYet
force-pushed
the
dante-dev
branch
10 times, most recently
from
cee19ff to
6bb7124
Compare
ZhangYet
force-pushed
the
dante-dev
branch
3 times, most recently
from
e44323a to
9812c9b
Compare
ZhangYet
force-pushed
the
dante-dev
branch
2 times, most recently
from
cfe636f to
4159296
Compare
yonghong-song
requested changes
Oct 2, 2024
ZhangYet
force-pushed
the
dante-dev
branch
2 times, most recently
from
4e1875c to
30ee67e
Compare
Sorry for the format issues. I kept switching development env between office and home, sometimes the fix was forget to push(like the space between Maybe we should provide a tool like |
Yes, it would be good if we have a checkpatch tool for all codes under libbpf-tools directory. |
tools/softirqs.py supports `-c/--cpu` otption to filter cpu, It's reasonable to support a same otption for libbpf-tools/softirqs. Add `-mcpu=v3` in Makefile for softirqs or the shift op will lead to verifier errors. Reported-by: Tang Yizhou <[email protected]> Signed-off-by: Dantezy <[email protected]>
Signed-off-by: Dantezy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since tools/hardirqs and tools/softirqs supports a
--cpuoption, it's reasonable to support a same option in libbpf version.