tools/tcpcong: Reduce code redundancy #5122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1: Ports that do not meet the conditions in function "entry_state_update_func" will not be stored in the "start_ipv4" or "start_ipv6", and the "ret_state_update_func" function will not obtain values, so there is no need to perform port filtering again. 2: Sock_store can be directly deleted in function "ret_func". Signed-off-by: Feng Yang <[email protected]>
kknjh
requested review from
brendangregg,
goldshtn and
davemarchevsky
as code owners
| @@ -274,7 +265,7 @@ | |||
| } | |||
| start_ipv6.delete(&key); | |||
| } | |||
| SOCK_STORE_DEL | |||
There was a problem hiding this comment.
How about the following prog?
KRETFUNC_PROBE(tcp_fastretrans_alert, struct sock *sk)
{
return ret_state_update_func(sk);
}
There was a problem hiding this comment.
if is_support_kfunc:
bpf_text += kfunc_program
bpf_text = bpf_text.replace('SOCK_STORE_DEF', '')
bpf_text = bpf_text.replace('SOCK_STORE_ADD', '')
bpf_text = bpf_text.replace('SOCK_STORE_DEL', '')
else:
bpf_text += kprobe_program
bpf_text = bpf_text.replace('SOCK_STORE_DEF',
'BPF_HASH(sock_store, process_key_t, struct sock *);')
bpf_text = bpf_text.replace('SOCK_STORE_ADD',
'sock_store.update(&key, &sk);')
bpf_text = bpf_text.replace('SOCK_STORE_DEL',
'sock_store.delete(&key);')
It does not use SOCK_STORE, so it does not affect
There was a problem hiding this comment.
Okay, I see. Indeed this is the case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1: Ports that do not meet the conditions in function "entry_state_update_func" will not be stored in the "start_ipv4" or "start_ipv6", and the "ret_state_update_func" function will not obtain values, so there is no need to perform port filtering again.
2: Sock_store can be directly deleted in function "ret_func".