Refactor configuration structure #652
Conversation
fmessmer
changed the title
|
Sorry, where's the advantage here? This just add new subfolders... |
fmessmer
force-pushed
the
refactor_configuration_structure
branch
from
97713f4 to
e3736cc
Compare
It's sync'ing the structure with the nav configuration and allows for a configuration within a single package, e.g. for demos, while keeping the various config sources grouped semantically without mixing them, i.e. eventually, #437 will introduce a |
fmessmer
force-pushed
the
refactor_configuration_structure
branch
3 times, most recently
from
33f8ca1 to
11e9e89
Compare
|
I consider this done so far.... @ipa-mig @ipa-fmw @ipa-nhg |
|
maybe we should rebase on top of #645 after that has been merged... |
| endforeach() | ||
| install(DIRECTORY robots | ||
| DESTINATION ${CATKIN_PACKAGE_SHARE_DESTINATION} | ||
| ) |
There was a problem hiding this comment.
This simplification is a nice side effect :-)
|
I understand the point of unify the configuration but I don't think this structure is the right one for cob_hardware_config, For this package make not sense, and it is the main configuration package of Care-O-bot. Last time we discussed the structure of cob_robots together, we decided to move into a new structure where we will only have component/module specific configuration and not robots anymore. And this pull request is actually doing the opposite. |
| @@ -1,6 +1,6 @@ | |||
| moveit_setup_assistant_config: | |||
| URDF: | |||
| package: cob_hardware_config | |||
| relative_path: cob4-7/urdf/cob4-7.urdf.xacro | |||
| relative_path: robots/cob4-7/urdf/cob4-7.urdf.xacro | |||
| SRDF: | |||
| relative_path: config/cob4-7.srdf | |||
There was a problem hiding this comment.
why do you keep only for cob_moveit_config the structure package_name/$(arg robot)/...
fmessmer
force-pushed
the
refactor_configuration_structure
branch
from
2d538e3 to
cf67d80
Compare
fmessmer
force-pushed
the
refactor_configuration_structure
branch
from
cfaf230 to
461b121
Compare
|
|
fmessmer
changed the title
as discussed with @ipa-mig and @ipa-fmw
this PR leads to changes in
additional refactoring is done in:
and then testing!