fix: adaptions for v2.1 #42
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbeutelspacher
changed the title
mbeutelspacher
force-pushed
the
feat/v2.1
branch
from
2b3f063
to
b79f095
Compare
ipa-pfs
reviewed
Sep 20, 2024
mbeutelspacher
force-pushed
the
feat/v2.1
branch
from
b79f095
to
6f177f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does not include Factsheet yet:
Up for debate if it is even worth having it as a ROS Message.
Additionally one may need special handling because the maxarraylens have fields that contains points
includes a check script that validates the Messages against the schema files in https://github.com/VDA5050/VDA5050/tree/main/json_schemas with
The check of Factsheet is skipped for now
The comments on the fields were not checked for correctness