Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cross-platform CI with conda packages #739

Merged
merged 2 commits into from
Apr 6, 2021

Conversation

Tobias-Fischer
Copy link
Contributor

Hi @wxmerkt,

This should save you from setting up Docker stuff. It runs a build using dependencies from conda-forge and other ROS packages build in RoboStack (https://github.com/RoboStack/ros-noetic). Feel free to play around to see whether you can find the Eigen issue. It would be really nice to see this PR merged :).

We have a similar PR in rviz: ros-visualization/rviz#1600

/cc @wolfv

@Tobias-Fischer
Copy link
Contributor Author

You can also easily setup a conda test locally for faster iterations - see https://github.com/RoboStack/ros-noetic/blob/master/CONTRIBUTING.md

When the build fails, the last line will be a command that you can run to go into the build environment for even faster iterations.

@Tobias-Fischer
Copy link
Contributor Author

GitHub actions in action: https://github.com/Tobias-Fischer/exotica/actions

@wxmerkt
Copy link
Collaborator

wxmerkt commented Apr 6, 2021

Fantastic, thank you! I was just looking at the RViz CI example :-D Ignore the latest comment in #737 please while I work with this branch :-).

@wxmerkt wxmerkt merged commit 4b3e853 into ipab-slmc:master Apr 6, 2021
@Tobias-Fischer
Copy link
Contributor Author

Oh wow, that was a quick merge - thanks!
I noticed that you probably need to set fail-fast: false - I should have tested Windows+OSX as well; I guess for now let's focus on the Linux build.

@Tobias-Fischer Tobias-Fischer deleted the conda-ci branch April 6, 2021 22:19
@wxmerkt
Copy link
Collaborator

wxmerkt commented Apr 6, 2021

Thanks - I commented Windows & Mac OS X for now to debug the Eigen issue and will then successively check how involved it would be to enable Mac OS X and potentially Windows. I'll keep you posted :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants