Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

first-interaction: Fix repository issues #204

Merged
merged 2 commits into from
Jul 14, 2022
Merged

Conversation

mestery
Copy link
Contributor

@mestery mestery commented Jul 14, 2022

Per [1], we need to use pull_request_target instead of pull_request
here. The tl;dr is that this runs as the users credentials, but they
may not have access to the repo.

See also [2].

[1] https://securitylab.github.com/research/github-actions-preventing-pwn-requests/
[2] actions/first-interaction#31

Signed-off-by: Kyle Mestery [email protected]

@mestery mestery requested a review from glimchb July 14, 2022 15:45
@mestery mestery self-assigned this Jul 14, 2022
Copy link
Contributor

@glimchb glimchb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

trust you on this, haven't read the documentation

here. The tl;dr is that this runs as the *users* credentials, but they
may not have access to the repo.

See also [2].

[1] https://securitylab.github.com/research/github-actions-preventing-pwn-requests/
[2] actions/first-interaction#31

Signed-off-by: Kyle Mestery <[email protected]>
@mestery mestery force-pushed the fix-first branch 5 times, most recently from 60b15df to d77900d Compare July 14, 2022 16:23
Signed-off-by: Kyle Mestery <[email protected]>
@mestery mestery merged commit 6f2485e into ipdk-io:main Jul 14, 2022
@mestery mestery deleted the fix-first branch July 14, 2022 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants