Skip to content
This repository has been archived by the owner on Mar 10, 2020. It is now read-only.

Commit

Permalink
fix: test skips and fix disconnect arg toString
Browse files Browse the repository at this point in the history
  • Loading branch information
Alan Shaw committed Jan 13, 2020
1 parent 0ac9c19 commit bd5f0ae
Show file tree
Hide file tree
Showing 2 changed files with 17 additions and 2 deletions.
2 changes: 1 addition & 1 deletion src/swarm/disconnect.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ module.exports = configure(({ ky }) => {
options = options || {}

const searchParams = new URLSearchParams(options.searchParams)
addrs.forEach(addr => searchParams.append('arg', addr))
addrs.forEach(addr => searchParams.append('arg', `${addr}`))

const res = await ky.post('swarm/disconnect', {
timeout: options.timeout,
Expand Down
17 changes: 16 additions & 1 deletion test/interface.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,18 @@ describe('interface-ipfs-core tests', () => {
}]
})

tests.bootstrap(commonFactory)
tests.bootstrap(commonFactory, {
skip: [{
name: 'should return a list containing the bootstrap peer when called with a valid arg (ip4)',
reason: 'TODO unskip when go-ipfs switches to p2p for libp2p keys'
}, {
name: 'should prevent duplicate inserts of bootstrap peers',
reason: 'TODO unskip when go-ipfs switches to p2p for libp2p keys'
}, {
name: 'should return a list containing the peer removed when called with a valid arg (ip4)',
reason: 'TODO unskip when go-ipfs switches to p2p for libp2p keys'
}]
})

tests.config(commonFactory, {
skip: [
Expand Down Expand Up @@ -125,6 +136,10 @@ describe('interface-ipfs-core tests', () => {
name: 'should ls directory',
reason: 'TODO unskip when go-ipfs supports --long https://github.com/ipfs/go-ipfs/pull/6528'
},
{
name: 'should list a file directly',
reason: 'TODO unskip when go-ipfs supports --long https://github.com/ipfs/go-ipfs/pull/6528'
},
{
name: 'should ls directory and include metadata',
reason: 'TODO not implemented in go-ipfs yet'
Expand Down

0 comments on commit bd5f0ae

Please sign in to comment.